Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create base MacOS CI pipeline #360

Closed

Conversation

laurynasas
Copy link
Contributor

This PR addresses a cross-platform wheels issue and adds support for building and uploading MacOS wheels for cp36, cp37, cp38, cp39 on x86_64 architecture.

@google-cla google-cla bot added the cla: yes Override CLA status to unblock PR. label Jun 8, 2021
@95-martin-orion
Copy link
Collaborator

From the checks this appears to be good to go. You can auto-apply formatting fixes with check/format-incremental --apply.

@95-martin-orion 95-martin-orion added the kokoro:run Trigger Kokoro builds for this PR. label Jun 10, 2021
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label Jun 10, 2021
with:
path: ./wheelhouse/*.whl

- name: Publish package
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the preferred way of doing this is to have a separate workflow with the on: release trigger.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's possible to share data between jobs but how is it possible to persist built wheels between workflows?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of persisting the wheel between workflows, we can just rebuild the wheel in the release workflow. (I usually cut releases via the Github API, which IIUC separates the "release" and "push" events.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that makes sense, I opened a new PR with the changes #379

Comment on lines +9 to +10
# The Kokoro MacOS VMs are not configured for AVX2 or OpenMP, so these modes
# are excluded from the build and test process.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update comments to refer to Github Actions, rather than Kokoro.

@laurynasas laurynasas closed this Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Override CLA status to unblock PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants