-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create base MacOS CI pipeline #360
Create base MacOS CI pipeline #360
Conversation
From the checks this appears to be good to go. You can auto-apply formatting fixes with |
with: | ||
path: ./wheelhouse/*.whl | ||
|
||
- name: Publish package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the preferred way of doing this is to have a separate workflow with the on: release
trigger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's possible to share data between jobs but how is it possible to persist built wheels between workflows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of persisting the wheel between workflows, we can just rebuild the wheel in the release workflow. (I usually cut releases via the Github API, which IIUC separates the "release" and "push" events.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that makes sense, I opened a new PR with the changes #379
# The Kokoro MacOS VMs are not configured for AVX2 or OpenMP, so these modes | ||
# are excluded from the build and test process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update comments to refer to Github Actions, rather than Kokoro.
This PR addresses a cross-platform wheels issue and adds support for building and uploading MacOS wheels for
cp36, cp37, cp38, cp39
onx86_64
architecture.