Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wheels in pypi packaging #313

Closed
95-martin-orion opened this issue Mar 19, 2021 · 3 comments
Closed

Use wheels in pypi packaging #313

95-martin-orion opened this issue Mar 19, 2021 · 3 comments
Assignees

Comments

@95-martin-orion
Copy link
Collaborator

The goal of this issue is to resolve #242 and #259.

Currently, pip install qsimcirq requires building qsim locally. This is fine for Linux, but (as seen in the issues above) often encounters difficulty on MacOS and Windows. In order to resolve this, we need to replace the current packaging with a portable wheel as described by PEP 513.

@95-martin-orion 95-martin-orion self-assigned this Mar 19, 2021
@95-martin-orion
Copy link
Collaborator Author

Comment from @Strilanc: cross-platform wheels may be tricky. Consider looking into cibuildwheel, which is how Stim builds for Mac and Windows.

@Strilanc
Copy link

Stim doesn't use cibuildwheels to make the wheels, it uses cibuildwheels to verify that the source compiles on other platforms. You can use it to build the wheels, but I'm not confident they will generalize beyond the build machines when AVX instructions are involved.

@95-martin-orion
Copy link
Collaborator Author

This has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants