Repository navigation
ci: resolve and build nightly SDKs for both master and wrynose - #33
Merged
Merged
Conversation
Hasibur Rahman Mohammed (hasiburr-qti)
requested review from
NaveenCherukuri (CherukuriNaveenQC) and
GirishKadirisani
as code owners
November 18, 2026 11:39
|
|
||
| - name: Report pending status on PR | ||
| uses: actions/github-script@v7 | ||
| uses: actions/github-script@v9 |
| steps: | ||
| - name: Report final status on PR | ||
| uses: actions/github-script@v7 | ||
| uses: actions/github-script@v9 |
Generalize the nightly SDK/image resolution and build pipeline so it
covers both the master and wrynose meta-qcom nightlies instead of
wrynose only. This re-introduces the resolve-nightly-download-url action
(previously reverted) on top of a build matrix that fans out per branch.
resolve-nightly-download-url:
- Resolve the latest successful compile_sdk run for both master and
wrynose via a reusable find_latest_successful_run() helper.
- Emit branch-keyed outputs:
sdk-url: {"master": "<url>", "wrynose": "<url>"}
image-urls: {"master": {"<target>/<type>": "<url>", ...},
"wrynose": {...}}
- Probe both toolchain filename conventions: release ("3.1.sh") and
snapshot ("2.99+snapshot.sh").
- Set inherit_errexit so a failed resolution aborts the step instead of
emitting an empty URL.
qimsdk-build.yml:
- Add a setup job that converts the branch-keyed sdk-url object into a
matrix include array of {branch, sdk_url}.
- Fan the build job out over that matrix, exposing both matrix.branch and
matrix.sdk_url, and produce per-branch artifacts.
ci/build.sh:
- Name the downloaded SDK and the output archive per branch.
qimsdk_compilation{,_pr}.yml:
- Point at the in-repo actions and bump github-script to v9.
Signed-off-by: Hasibur Rahman Mohammed <hasiburr@qti.qualcomm.com>
Hasibur Rahman Mohammed (hasiburr-qti)
force-pushed
the
fix_urls_v2
branch
from
November 18, 2026 11:40
e4fecfa to
7061fec
Compare
| - name: Resolve SDK URL from latest nightly | ||
| id: urls | ||
| uses: qualcomm/gst-plugins-imsdk/.github/actions/resolve-nightly-download-url@main | ||
| uses: ./.github/actions/resolve-nightly-download-url |
| - name: Resolve SDK URL from latest nightly | ||
| id: urls | ||
| uses: qualcomm/gst-plugins-imsdk/.github/actions/resolve-nightly-download-url@main | ||
| uses: ./.github/actions/resolve-nightly-download-url |
| - name: Post check run | ||
| id: post-check-run | ||
| uses: qualcomm/gst-plugins-imsdk/.github/actions/check-run@main | ||
| uses: ./.github/actions/check-run |
GirishKadirisani
approved these changes
Nov 18, 2026
Hasibur Rahman Mohammed (hasiburr-qti)
added a commit
to hasiburr-qti/qimsdk
that referenced
this pull request
Nov 18, 2026
PR qualcomm#33 referenced the per-branch build matrix values as matrix.include.branch / matrix.include.sdk_url, but when a matrix is defined via `include:` its entry keys are exposed as top-level matrix properties. There is no `matrix.include` context, so those expressions resolved to empty strings, leaving BRANCH and SDK_OBJECT_URL unset and failing ci/build.sh at the SDK download step. Reference the values as matrix.branch and matrix.sdk_url. Signed-off-by: Hasibur Rahman Mohammed <hasiburr@qti.qualcomm.com>
GirishKadirisani
pushed a commit
that referenced
this pull request
Nov 18, 2026
PR #33 referenced the per-branch build matrix values as matrix.include.branch / matrix.include.sdk_url, but when a matrix is defined via `include:` its entry keys are exposed as top-level matrix properties. There is no `matrix.include` context, so those expressions resolved to empty strings, leaving BRANCH and SDK_OBJECT_URL unset and failing ci/build.sh at the SDK download step. Reference the values as matrix.branch and matrix.sdk_url. Signed-off-by: Hasibur Rahman Mohammed <hasiburr@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generalizes the nightly SDK/image resolution and build pipeline to cover both the
masterandwrynosemeta-qcom nightlies instead ofwrynoseonly. This re-introduces theresolve-nightly-download-urlaction (reverted in #32) on top of a per-branch build matrix.Changes
resolve-nightly-download-urlactioncompile_sdkrun for bothmasterandwrynose(reusablefind_latest_successful_run()helper).sdk-url→{"master": "<url>", "wrynose": "<url>"}image-urls→{"master": {"<target>/<type>": "<url>", ...}, "wrynose": {...}}…-3.1.sh) and snapshot (…-2.99+snapshot.sh).shopt -s inherit_errexitso a failed resolution fails the step instead of emitting an empty URL.qimsdk-build.ymlsetupjob converts the branch-keyedsdk-urlobject into a matrixincludearray of{branch, sdk_url}.buildjob fans out over the matrix, exposingmatrix.branchandmatrix.sdk_url, and produces per-branch artifacts.ci/build.shsdk-${BRANCH}.sh,qimsdk-artifacts-${BRANCH}.tar.gz).qimsdk_compilation.yml/qimsdk_compilation_pr.ymlactions/github-scriptto v9.Note
The compilation workflows reference the local actions as
uses: $/.github/actions/….$/is not valid syntax for a local action (should be./.github/actions/…) — flagging in case it needs addressing before merge.🤖 Generated with Claude Code