Skip to content

qimsdk-build: fix matrix context references for include entries - #34

Merged
GirishKadirisani merged 1 commit into
qualcomm:mainfrom
hasiburr-qti:fix_build
Nov 18, 2026
Merged

GirishKadirisani merged 1 commit into
qualcomm:mainfrom
hasiburr-qti:fix_build

Conversation

@hasiburr-qti

Copy link
Copy Markdown
Contributor

Summary

Follow-up fix for #33. The per-branch build matrix in qimsdk-build.yml referenced its values as matrix.include.branch / matrix.include.sdk_url, but when a matrix is defined with include:, the entry keys are exposed as top-level matrix properties — there is no matrix.include context.

As a result the expressions resolved to empty strings, so the build job ran with BRANCH= and SDK_OBJECT_URL= unset and failed at the SDK download step:

Downloading SDK
Error: Process completed with exit code 1.

Fix

Reference the matrix values directly as matrix.branch and matrix.sdk_url.

🤖 Generated with Claude Code

PR qualcomm#33 referenced the per-branch build matrix values as
matrix.include.branch / matrix.include.sdk_url, but when a matrix is
defined via `include:` its entry keys are exposed as top-level matrix
properties. There is no `matrix.include` context, so those expressions
resolved to empty strings, leaving BRANCH and SDK_OBJECT_URL unset and
failing ci/build.sh at the SDK download step.

Reference the values as matrix.branch and matrix.sdk_url.

Signed-off-by: Hasibur Rahman Mohammed <hasiburr@qti.qualcomm.com>
@GirishKadirisani
GirishKadirisani merged commit 6ea6d8b into qualcomm:main Nov 18, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants