Repository navigation
qimsdk-build: fix matrix context references for include entries - #34
Merged
Merged
Conversation
PR qualcomm#33 referenced the per-branch build matrix values as matrix.include.branch / matrix.include.sdk_url, but when a matrix is defined via `include:` its entry keys are exposed as top-level matrix properties. There is no `matrix.include` context, so those expressions resolved to empty strings, leaving BRANCH and SDK_OBJECT_URL unset and failing ci/build.sh at the SDK download step. Reference the values as matrix.branch and matrix.sdk_url. Signed-off-by: Hasibur Rahman Mohammed <hasiburr@qti.qualcomm.com>
Hasibur Rahman Mohammed (hasiburr-qti)
requested review from
NaveenCherukuri (CherukuriNaveenQC) and
GirishKadirisani
as code owners
November 18, 2026 12:05
GirishKadirisani
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fix for #33. The per-branch build matrix in
qimsdk-build.ymlreferenced its values asmatrix.include.branch/matrix.include.sdk_url, but when a matrix is defined withinclude:, the entry keys are exposed as top-level matrix properties — there is nomatrix.includecontext.As a result the expressions resolved to empty strings, so the build job ran with
BRANCH=andSDK_OBJECT_URL=unset and failed at the SDK download step:Fix
Reference the matrix values directly as
matrix.branchandmatrix.sdk_url.🤖 Generated with Claude Code