Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions setup/vendor_bill_final_price_check/setup.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import setuptools

setuptools.setup(
setup_requires=['setuptools-odoo'],
odoo_addon=True,
)
59 changes: 59 additions & 0 deletions vendor_bill_final_price_check/README.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
=============================
Vendor Bill Final Price Check
=============================

.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
:target: https://odoo-community.org/page/development-status
:alt: Beta
.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3
.. |badge3| image:: https://img.shields.io/badge/github-qrtl%2Faxls--oca-lightgray.png?logo=github
:target: https://github.com/qrtl/axls-oca/tree/16.0/vendor_bill_final_price_check
:alt: qrtl/axls-oca

|badge1| |badge2| |badge3|

This module does the following-
- Add confirm_final_price and is_change_price field in account.move
- Add menuitem for account manager to allow confirm for the bills that change the price.

This module restricts the user to confirm the vendor bills if the price in account.move.line is changed.

Currently odoo having issue to correct valuation layer and reset to draft button on bill also hidden after price is changed and confirm bills.
So,the purpose of this module is to make sure that if there's a price change on the move line, the change is a final price.

**Table of contents**

.. contents::
:local:

Bug Tracker
===========

Bugs are tracked on `GitHub Issues <https://github.com/qrtl/axls-oca/issues>`_.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us smashing it by providing a detailed and welcomed
`feedback <https://github.com/qrtl/axls-oca/issues/new?body=module:%20vendor_bill_final_price_check%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.

Do not contact contributors directly about support or help with technical issues.

Credits
=======

Authors
~~~~~~~

* Quartile Limited

Maintainers
~~~~~~~~~~~

This module is part of the `qrtl/axls-oca <https://github.com/qrtl/axls-oca/tree/16.0/vendor_bill_final_price_check>`_ project on GitHub.

You are welcome to contribute.
1 change: 1 addition & 0 deletions vendor_bill_final_price_check/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from . import models
13 changes: 13 additions & 0 deletions vendor_bill_final_price_check/__manifest__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Copyright 2023 Quartile Limited
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

{
"name": "Vendor Bill Final Price Check",
"version": "16.0.1.0.0",
"license": "AGPL-3",
"author": "Quartile Limited, Odoo Community Association (OCA)",
"website": "https://www.quartile.co",
"depends": ["purchase_stock"],
"data": ["views/account_move_views.xml"],
"installable": True,
}
2 changes: 2 additions & 0 deletions vendor_bill_final_price_check/models/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
from . import account_move
from . import account_move_line
17 changes: 17 additions & 0 deletions vendor_bill_final_price_check/models/account_move.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Copyright 2023 Quartile Limited
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

from odoo import _, fields, models
from odoo.exceptions import ValidationError


class AccountMove(models.Model):
_inherit = "account.move"

confirm_final_price = fields.Boolean()
is_change_price = fields.Boolean()

def _post(self, soft=True):
if not self.confirm_final_price and self.is_change_price:
raise ValidationError(_("This document is needed to confirm by manager."))
return super()._post(soft)
20 changes: 20 additions & 0 deletions vendor_bill_final_price_check/models/account_move_line.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# Copyright 2023 Quartile Limited
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

from odoo import api, models


class AccountMoveLine(models.Model):
_inherit = "account.move.line"

@api.onchange("price_unit")
def _onchange_price_unit(self):
for line in self:
if not line.move_id.move_type == "in_invoice":
return

if not line.purchase_line_id:
return

if line.product_id and line.product_id.cost_method != "standard":
line._origin.move_id.write({"is_change_price": True})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only covers a partial (minor) scenario and we cannot rely on this approach. This logic doesn't cover, for example, the case where SVL is generated due to exchange rate difference between receipt and vendor bill. What I had in mind was to insert a check where SVL record is created.

8 changes: 8 additions & 0 deletions vendor_bill_final_price_check/readme/DESCRIPTION.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
This module does the following-
- Add confirm_final_price and is_change_price field in account.move
- Add menuitem for account manager to allow confirm for the bills that change the price.

This module restricts the user to confirm the vendor bills if the price in account.move.line is changed.

Currently odoo having issue to correct valuation layer and reset to draft button on bill also hidden after price is changed and confirm bills.
So,the purpose of this module is to make sure that if there's a price change on the move line, the change is a final price.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading