Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions setup/vendor_bill_final_price_check/setup.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import setuptools

setuptools.setup(
setup_requires=['setuptools-odoo'],
odoo_addon=True,
)
59 changes: 59 additions & 0 deletions vendor_bill_final_price_check/README.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
=============================
Vendor Bill Final Price Check
=============================

.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
:target: https://odoo-community.org/page/development-status
:alt: Beta
.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3
.. |badge3| image:: https://img.shields.io/badge/github-qrtl%2Faxls--oca-lightgray.png?logo=github
:target: https://github.com/qrtl/axls-oca/tree/16.0/vendor_bill_final_price_check
:alt: qrtl/axls-oca

|badge1| |badge2| |badge3|

This module does the following-
- Add confirm_final_price and is_change_price field in account.move
- Add menuitem for account manager to allow confirm for the bills that change the price.

This module restricts the user to confirm the vendor bills if the price in account.move.line is changed.

Currently odoo having issue to correct valuation layer and reset to draft button on bill also hidden after price is changed and confirm bills.
So,the purpose of this module is to make sure that if there's a price change on the move line, the change is a final price.

**Table of contents**

.. contents::
:local:

Bug Tracker
===========

Bugs are tracked on `GitHub Issues <https://github.com/qrtl/axls-oca/issues>`_.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us smashing it by providing a detailed and welcomed
`feedback <https://github.com/qrtl/axls-oca/issues/new?body=module:%20vendor_bill_final_price_check%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.

Do not contact contributors directly about support or help with technical issues.

Credits
=======

Authors
~~~~~~~

* Quartile Limited

Maintainers
~~~~~~~~~~~

This module is part of the `qrtl/axls-oca <https://github.com/qrtl/axls-oca/tree/16.0/vendor_bill_final_price_check>`_ project on GitHub.

You are welcome to contribute.
1 change: 1 addition & 0 deletions vendor_bill_final_price_check/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from . import models
13 changes: 13 additions & 0 deletions vendor_bill_final_price_check/__manifest__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Copyright 2023 Quartile Limited
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

{
"name": "Vendor Bill Final Price Check",
"version": "16.0.1.0.0",
"license": "AGPL-3",
"author": "Quartile Limited, Odoo Community Association (OCA)",
"website": "https://www.quartile.co",
"depends": ["purchase_stock"],
"data": ["views/account_move_views.xml"],
"installable": True,
}
2 changes: 2 additions & 0 deletions vendor_bill_final_price_check/models/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
from . import account_move
from . import account_move_line
18 changes: 18 additions & 0 deletions vendor_bill_final_price_check/models/account_move.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Copyright 2023 Quartile Limited
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

from odoo import api, fields, models


class AccountMove(models.Model):
_inherit = "account.move"

confirm_final_price = fields.Boolean(tracking=True)
is_update_svl = fields.Boolean(
compute="_compute_svl_check", store=True, readonly=False
)

@api.depends("date")
def _compute_svl_check(self):
for line in self.filtered(lambda move: move.state != "posted").invoice_line_ids:
line._check_svl_create()
77 changes: 77 additions & 0 deletions vendor_bill_final_price_check/models/account_move_line.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
# Copyright 2023 Quartile Limited
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

from odoo import _, models
from odoo.exceptions import ValidationError
from odoo.tools.float_utils import float_is_zero


class AccountMoveLine(models.Model):
_inherit = "account.move.line"

def _create_in_invoice_svl(self):
svl = super(AccountMoveLine, self)._create_in_invoice_svl()
if svl and not self.move_id.confirm_final_price:
raise ValidationError(
_("This document will create new SVL and need to confirm by Manager.")
)
return svl

def _check_svl_create(self):
svl_vals_list = []
for line in self:
if line.move_id.move_type not in ("in_invoice", "in_refund", "in_receipt"):
return

if not line.purchase_line_id:
return

if line.product_id and line.product_id.cost_method != "standard":
# Reference _create_in_invoice_svl function to check this document
# will create new svl for updating is_update_svl flag for showing list of Bills
# to allow price change for manager.
line = line.with_company(line.company_id)
move = line.move_id.with_company(line.move_id.company_id)
po_line = line.purchase_line_id
uom = line.product_uom_id or line.product_id.uom_id

quantity = po_line.qty_received - (po_line.qty_invoiced - line.quantity)
quantity = max(min(line.quantity, quantity), 0)
if float_is_zero(quantity, precision_rounding=uom.rounding):
continue

layers = line._get_stock_valuation_layers(move)
if not layers:
continue

price_unit = (
-line.price_unit
if move.move_type == "in_refund"
else line.price_unit
)
price_unit = price_unit * (1 - (line.discount or 0.0) / 100.0)
if line.tax_ids:
prec = 1e6
price_unit *= prec
price_unit = line.tax_ids.with_context(round=False).compute_all(
price_unit,
currency=move.currency_id,
quantity=1.0,
is_refund=move.move_type == "in_refund",
fixed_multiplicator=move.direction_sign,
)["total_excluded"]
price_unit /= prec
layers_price_unit = line._get_stock_valuation_layers_price_unit(layers)
layers_to_correct = line._get_stock_layer_price_difference(
layers, layers_price_unit, price_unit
)
svl_vals_list += line._prepare_in_invoice_svl_vals(layers_to_correct)

if svl_vals_list:
self.move_id.write({"is_update_svl": True})
else:
self.move_id.write({"is_update_svl": False})

def write(self, vals):
self._check_svl_create()
return super().write(vals)
8 changes: 8 additions & 0 deletions vendor_bill_final_price_check/readme/DESCRIPTION.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
This module does the following-
- Add confirm_final_price and is_update_svl field in account.move
- Add menuitem for account manager to allow confirm for the bills that change the price.

This module restricts the user to confirm the vendor bills if the price in account.move.line is changed.

Currently odoo having issue to correct valuation layer and reset to draft button on bill also hidden after price is changed and confirm bills.
So,the purpose of this module is to make sure that if there's a price change on the move line, the change is a final price.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading