allows to list existing and upload new datasets #4
Conversation
There was a problem hiding this comment.
Dear @wow-such-code ! Awesome work, however i found some inconsistencies and minor issues which should be addressed beforehand
src/main/java/life/qbic/App.java
Outdated
| */ | ||
| public static OpenBIS loginToOpenBIS( | ||
| char[] password, String user, String url, String dssUrl) { | ||
| //setupLog(); |
There was a problem hiding this comment.
| //setupLog(); | |
| //setupLog(); |
Why is this commented out? Is this not necessary anymore 🤔
pom.xml
Outdated
| <configuration> | ||
| <source>11</source> | ||
| <target>11</target> | ||
| </configuration> |
There was a problem hiding this comment.
I think this relates to the java version? I'd recommend to define a java property then and employ it here
src/main/java/life/qbic/io/commandline/AuthenticationOptions.java
Outdated
Show resolved
Hide resolved
src/main/java/life/qbic/io/commandline/AuthenticationOptions.java
Outdated
Show resolved
Hide resolved
src/main/java/life/qbic/io/commandline/AuthenticationOptions.java
Outdated
Show resolved
Hide resolved
| creation.setExperimentId(new ExperimentIdentifier(experimentID)); | ||
| creation.setParentIds(parentCodes.stream().map(DataSetPermId::new).collect( | ||
| Collectors.toList())); | ||
| creation.setTypeId(new EntityTypePermId("UNKNOWN", EntityKind.DATA_SET)); |
There was a problem hiding this comment.
NIT: Do you think i'd make sense to specify these values as final static variables with a descriptive name? For me it's unclear what the purpose of UNKOWN is in this context 🤔
There was a problem hiding this comment.
good point, at this point it's a proof of concept and "UNKNOWN" is the dataset type we can be sure of existing in the system
| public void downloadDataset(String targetPath, String datasetID) throws IOException { | ||
| DataSetFileDownloadOptions options = new DataSetFileDownloadOptions(); | ||
| IDataSetFileId fileToDownload = new DataSetFilePermId(new DataSetPermId(datasetID), | ||
| "");//TODO test this path |
There was a problem hiding this comment.
What's ths status of this TODO?
Uh oh!
There was an error while loading. Please reload this page.