Extend timeout deadline for timed out health tests #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66548226 |
Summary: Some health tests were timing out due to a preset timeout deadline of 10k ms. See e.g., here: https://www.internalfb.com/sandcastle/workflow/351280770940024747/artifact/actionlog.351280771033318826.stdout.1 {F1968816841} Updated the timeout deadline to 40k ms, since most timed out tests fall within this duration. Differential Revision: D66548226
iden-kalemaj
force-pushed
the
export-D66548226
branch
from
c42f18d to
203292c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66548226 |
|
This pull request has been merged in 10eb10a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Some health tests were timing out due to a preset timeout deadline of 10k ms. See e.g., here: https://www.internalfb.com/sandcastle/workflow/351280770940024747/artifact/actionlog.351280771033318826.stdout.1
{F1968816841}
Updated the timeout deadline to 40k ms, since most timed out tests fall within this duration.
Differential Revision: D66548226