Skip to content

Commit

Permalink
Extend timeout deadline for timed out health tests (#691)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #691

Some health tests were timing out due to a preset timeout deadline of 10k ms. See e.g., here: https://www.internalfb.com/sandcastle/workflow/351280770940024747/artifact/actionlog.351280771033318826.stdout.1

{F1968816841}

Updated the timeout deadline to 40k ms, since most timed out tests fall within this duration.

Reviewed By: HuanyuZhang

Differential Revision: D66548226

fbshipit-source-id: 9f6ccd963ca9b2f72e4d6269cf54ec997b374e0d
  • Loading branch information
iden-kalemaj authored and facebook-github-bot committed Dec 3, 2024
1 parent 61ae0ea commit 10eb10a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion opacus/tests/accountants_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def test_get_noise_multiplier_prv_steps(self) -> None:
),
delta=st.sampled_from([1e-4, 1e-5, 1e-6]),
)
@settings(deadline=10000)
@settings(deadline=40000)
def test_get_noise_multiplier_overshoot(self, epsilon, epochs, sample_rate, delta):
noise_multiplier = get_noise_multiplier(
target_epsilon=epsilon,
Expand Down
4 changes: 2 additions & 2 deletions opacus/tests/batch_memory_manager_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def _init_training(self, batch_size=10, **data_loader_kwargs):
batch_size=st.sampled_from([8, 16, 64]),
max_physical_batch_size=st.sampled_from([4, 8]),
)
@settings(suppress_health_check=list(HealthCheck), deadline=10000)
@settings(suppress_health_check=list(HealthCheck), deadline=40000)
def test_basic(
self,
num_workers: int,
Expand Down Expand Up @@ -119,7 +119,7 @@ def test_basic(
num_workers=st.integers(0, 4),
pin_memory=st.booleans(),
)
@settings(suppress_health_check=list(HealthCheck), deadline=10000)
@settings(suppress_health_check=list(HealthCheck), deadline=40000)
def test_empty_batch(
self,
num_workers: int,
Expand Down
4 changes: 2 additions & 2 deletions opacus/tests/per_sample_gradients_utils_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def per_sample_grads_utils_test(
groups=st.integers(1, 12),
grad_sample_mode=st.sampled_from(get_grad_sample_modes(use_ew=True)),
)
@settings(deadline=10000)
@settings(deadline=40000)
def test_conv1d(
self,
N: int,
Expand Down Expand Up @@ -120,7 +120,7 @@ def test_conv1d(
batch_first=st.booleans(),
grad_sample_mode=st.sampled_from(get_grad_sample_modes(use_ew=True)),
)
@settings(deadline=10000)
@settings(deadline=40000)
def test_linear(
self,
N: int,
Expand Down

0 comments on commit 10eb10a

Please sign in to comment.