Repository navigation
Cover CUDA 13.4 in the Windows CUDA pull request jobs - #25307
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/25307
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e00a742 with merge base e1390b6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
@claude review effort=max |
|
Claude finished @Gasoonjia's task in 28m 19s —— View job Request Changes: the new CUDA 13.4 export row shares the e2e job's matrix-wide Detailed reviewPR Review: #25307SummaryThe PR adds a CUDA 13.4 dinov2 row to the Windows export and e2e matrices, runs
Infrastructure1. The new 13.4 export row can skip all seven e2e rows (
2. The export job now runs this script for the 13.4 row, but the script is missing from
3. (Low confidence) The 13.4 e2e row may load the 13.2 CUDA runtime Line 269 prepends only Every 13.x train names its runtime If the 13.2 copy wins, the row still passes, because Testing4. The 13.4 row covers less than its comment says (lines 109-110 and 244-245) The comment and the PR description say only the toolkit differs between trains. The Linux export also installs a different torch per train (
The model also decides which backend kernels run. So on 13.4, neither the int4 export path under that torch nor Either add one quantized 13.4 row, for example 5. The new tests check which trains the matrices list, not that the jobs use them
6. It used to assert
Assert that the non-dinov2 rows use Specific Comments
RecommendationRequest Changes. Finding 1 is a small Review steps
|
|
Addressed in a2e42ab:
Also:
|
|
@claude review effort=max |
|
Claude finished @Gasoonjia's task in 32m 19s —— View job Request Changes: the CUDA 13.4 int4 row added in a2e42ab ( Detailed reviewPR Review: #25307SummaryThe PR runs the Windows CUDA export, e2e and runtime-test jobs on both 13.2 and 13.4. The export job fetches the 13.4 toolkits itself when the image's nvcc doesn't match, and
InfrastructureThe runtime job installs torch before it puts the row's toolkit on The two jobs set up
Low confidence: I couldn't read test-infra's Related: the e2e TestingThe 13.4 int4 row never calls The new comment says this row "runs the int4 kernels the non-quantized model does not". It doesn't:
So no 13.4 job runs
Specific Comments
RecommendationRequest Changes. The Testing finding leaves open the coverage gap that the row was added to close, and the comment says the gap is closed. Swapping the row or rewording the comment resolves it. The Infrastructure finding is low confidence, and the rest is optional. Review steps
Not run: |
|
Addressed in 1c3cfb3:
|
|
@claude review effort=max |
|
Claude finished @Gasoonjia's task in 28m 50s —— View job I found nothing blocking: 1c3cfb3 resolves every round 2 finding and only two wrong comments and an order-dependent slice in the test remain, so I recommend Approve once the 13.4 rows pass (they were still running when I reviewed). Detailed reviewPR Review: #25307SummaryThis PR runs the Windows CUDA pull request jobs (export, e2e and runtime unit tests) on 13.4 as well as 13.2. It adds a Specific Comments
RecommendationApprove. Nothing blocks; the notes above are about wording. The 13.4 rows haven't been shown to work yet. When I reviewed, every export and runtime job for 1c3cfb3 was still running and no e2e row had started. That leaves two things unconfirmed: the 13.4 Windows toolkit ( Heads-up: Review steps
Not run:
|
a874e5e to
c8d4223
Compare
|
Rebased onto main after #25284 landed ( @claude review effort=max |
|
Claude finished @Gasoonjia's task in 27m 36s —— View job I'd approve once the 13.4 rows in the running CI pass on torch 2.15.0. Nothing blocks: what's left is a minor gap in Detailed reviewPR Review: #25307SummaryThe PR runs the Windows CUDA export, e2e and runtime jobs on CUDA 13.4 as well as 13.2. The 13.4 export rows fetch their own Linux nvcc and Windows cudart with Nothing blocks. One minor test-helper gap and some stale wording remain. The 13.4 Voxtral Realtime export and both 13.4 e2e rows haven't passed in CI yet. Run 44834278062 for Testing
Specific Comments
RecommendationApprove once the 13.4 rows in run 44834278062 pass. No 13.4 row has passed yet on torch 2.15.0+cu134 with the regenerated shims Review steps
|
_matrix_cuda_versions asserted nothing about exclude rows that name other keys along with the CUDA version; one could drop every row of a train and the coverage test would still count it. Reject them instead. The e2e gate comment's example was the per-train nightly pin #25284 removed.
|
Addressed in f7aef94:
CI on c8d4223: all 364 checks pass.
This push changes only the test helper and a comment. @claude review effort=max |
|
Claude finished @Gasoonjia's task in 28m 42s —— View job Review of f7aef94: I recommend Approve once run 44854278127 finishes green; nothing blocks, and the details below have one minor test gap, one question about the path filters and four wording nits. Detailed reviewPR Review: #25307SummaryThe PR gives the Windows CUDA export, e2e and runtime jobs a There are no blocking issues. f7aef94 changes only the test helper and a comment (
Infrastructure
Testing
Specific Comments
RecommendationApprove. Nothing blocks. The test gap is a one-line Review steps
|
…ording Only the export's torch-train assert sees which torch did a 13.4 export, since the Windows e2e runs CPU torch, so the test now pins it along with the PATH and CUDACXX exports that choose the nvcc. The export test is renamed for what it checks now, and three comments are reworded.
|
Addressed in the latest push:
|
|
@claude review effort=max |
|
Claude finished @Gasoonjia's task in 28m 52s —— View job Nothing blocks; there's one optional follow-up (the new toolkit switch copies the wheel pipeline's) and one comment-wording nit, so I recommend Approve. CI for Detailed reviewPR Review: #25307SummaryThe PR runs the Windows CUDA export, e2e and runtime jobs on both 13.2 and 13.4. Rows for a train other than the image's fetch that train's toolkit with Code Quality
Specific Comments
RecommendationApprove. Nothing blocks, and both points above are optional. CI for Review steps
|
Follow-up to #25255. Rebased onto #25284 (
e1390b6acb), so the 13.4 rows now install the torch 2.15.0 release, and the regeneratedaoti_cuda_shims.libhasaoti_torch_dtype_element_size. Also triggers ontorch_pin.py, sinceaoti_cuda_shims.libhas to move with the torch pin.Why
PyTorch publishes CUDA 13.2 and 13.4 wheels (torch 2.15.0 is on
whl/cu132andwhl/cu134, not onwhl/cu130), and ExecuTorch'sSUPPORTED_CUDA_VERSIONSis(13, 2), (13, 4). But every job incuda-windows.ymlran 13.2 only, because theexecutorch-ubuntu-22.04-cuda-windowsimage carries one train's toolkits. The only 13.4 Windows cross-compile was in the nightly wheel pipeline, so a pull request that broke it could land green.What
cuda-version, the same key ascuda.ymlandbuild-wheels-cuda-windows.yml).install_cuda_redist.py, as the wheel pipeline does. The image is unchanged.install_executorch.shpicked a torch built for that train.quantized-int4-tile-packed, the only quant here that lowers to_weight_int4pack_mmand so runs theint4mmshim built by that train's nvcc. It already runs on 13.2.build-wheels-cuda-windows.yml. One row's failed export, say one model's, no longer skips the other rows; each row fails on its own missing artifact. A skipped export (fork PR) still skips e2e.unittest-cuda-runtime-windows: runs on both trains. The Windows GPU runners already carry thev13.4toolkit.CUDA_HOME\bin\x64;CUDA_HOME\binfirst onPATH, before setup, astest_cuda_runtime_windows.ps1and the wheel e2e script do..ci/scripts/wheel/install_cuda_redist.py, and ontorch_pin.py,install_requirements.pyandinstall_utils.py.TORCH_VERSIONlives intorch_pin.py, whichinstall_requirements.pyreads, andinstall_utils.pyholdsSUPPORTED_CUDA_VERSIONS. The torch pin is there becauseaoti_cuda_shims.libhas to move with it.<job>-<cuda-version> (<model>, <quant>). GitHub cuts generated names at 100 characters, which gave the 13.2 and 13.4 Voxtral Realtime rows the same name.test_cuda_workflow.py: reads each job's train from the matrix key itsgpu-arch-versionnames, and checks that:gpu-arch-version, theCUDA\vpath,bin\x64before setup);WINDOWS_CUDA_HOME;Test plan
pytest .ci/scripts/tests/test_cuda_workflow.py .ci/scripts/tests/test_filter_cuda_matrix.py: 36 passed.== 'success';v13.2orgpu-arch-version: "13.2";bin\x64on PATH (e2e or runtime);excludethat names other keys along withcuda-version, which could drop every row of a train;.ci/scripts/testshas the same 36 environment failures/errors (missing local deps or env vars) with and without this change.install_cuda_redist.py --train 13.4 --platform windows-x86_64 --components cuda_cudartgivesbin/x64/cudart64_13.dllandlib/x64/cudart.lib. Those are the pathstorch.utils.cpp_extension(WINDOWS_CUDA_HOME/lib/x64) and Inductor's MinGW import-library step (bin/x64) read.c8d4223536(rebased onto Use torch 2.15.0 for every CUDA train #25284, torch 2.15.0): all 364 checks pass.aoti_torch_dtype_element_sizefrom the regeneratedaoti_cuda_shims.lib.unittest-cuda-runtime-windows-13.2and-13.4pass. The 13.4 runtime job built withv13.4\bin\nvcc.exe.