Repository navigation
Commit a874e5e
committed
Address review: check rendered names, honor include/exclude, drop LD_LIBRARY_PATH
- The test renders each row's check name from the template and requires the
names to be unique and at most 100 characters. An explicit name stops GitHub
appending matrix values, so a prefix check alone let six rows share a name.
- _matrix_cuda_versions adds include values to the axis and removes exclude
values, so an exclude that drops a train fails the coverage test.
- Drop the LD_LIBRARY_PATH export from the toolkit switch, matching the wheel
pipeline's copy: nvcc finds its own libraries, and the export links nothing
against the Linux runtime.
- Comment wording: bin\x64 goes ahead of bin on PATH; only the export has its
own torch; the gate test is named per row.1 parent fec953f commit a874e5e
2 files changed
Lines changed: 31 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
40 | 52 | | |
41 | 53 | | |
42 | 54 | | |
| |||
104 | 116 | | |
105 | 117 | | |
106 | 118 | | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
107 | 126 | | |
108 | 127 | | |
109 | 128 | | |
| |||
113 | 132 | | |
114 | 133 | | |
115 | 134 | | |
116 | | - | |
117 | | - | |
118 | | - | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
119 | 138 | | |
120 | 139 | | |
121 | 140 | | |
| |||
134 | 153 | | |
135 | 154 | | |
136 | 155 | | |
137 | | - | |
| 156 | + | |
138 | 157 | | |
139 | 158 | | |
140 | 159 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
115 | | - | |
116 | | - | |
117 | | - | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
118 | 119 | | |
119 | 120 | | |
120 | 121 | | |
| |||
166 | 167 | | |
167 | 168 | | |
168 | 169 | | |
169 | | - | |
170 | 170 | | |
171 | 171 | | |
172 | 172 | | |
| |||
0 commit comments