Repository navigation
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/25157
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 2 Unclassified FailuresAs of commit 5d8793f with merge base 351e938 ( NEW FAILURES - The following jobs have failed:
UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
@claude review effort=xhigh |
|
Claude finished @rascani's task in 3m 41s —— View job This PR adds optional ESP-NN 1.5.0 scratch-size pybind11 modules (one per kernel profile) and an Detailed reviewPR Review: #25157SummaryThe PR adds four profile-specific host modules ( The main problems:
The ESP-NN sources aren't on this runner and network access was blocked. Every claim below that depends on vendor arithmetic or parameter types is marked as suspected. API Design
Infrastructure
Code Quality
Testing
RecommendationRequest Changes Blocking: the CI step can't fail when the bindings are missing or broken, and the |
2aa9249 to
919c812
Compare
95a06a1 to
653ddfa
Compare
653ddfa to
10bd570
Compare
JakeStevens
left a comment
There was a problem hiding this comment.
make sure:
catch only ModuleNotFoundError where e.name is the requested module name. test_missing_binding still passes with that change, because a None entry in sys.modules raises ModuleNotFoundError with name set to that module.
is fixed
JakeStevens
left a comment
There was a problem hiding this comment.
make sure:
catch only ModuleNotFoundError where e.name is the requested module name. test_missing_binding still passes with that change, because a None entry in sys.modules raises ModuleNotFoundError with name set to that module.
is fixed
|
@claude /pr-review recheck findings |
|
Claude finished @rascani's task in 47m 22s —— View job PR Review: #25157 (recheck)JakeStevens' import-fallback condition is now met, but the code cited by the 919c812 review hasn't changed, so its eight findings are still open, five new ones were found, and the verdict stays Request Changes. Detailed reviewSummaryThis PR adds optional pybind11 bindings for ESP-NN 1.5.0's scratch-size getters, with one module per kernel profile. It also adds an Recheck:
Code Quality
Infrastructure
Testing
API Design
RecommendationRequest Changes Blocking:
The host-to-device size comparison can land with #25154, but it should exist before anything plans scratch from these values. Everything else is minor. JakeStevens' condition is met.
|
Expose all seven ESP-NN 1.5.0 scratch-size APIs through typed pybind11 functions with named arguments. EspTarget and EspKernelMode select S3, RISC-V PIE, generic optimized, or ANSI queries from the vendor sources. Keep the bindings optional in main CMake and Python packaging, with a standalone sizing-only build and a local source override. Verify query results and dimension bounds in the optimized ESP CI job. Operator lowering and device scratch allocation are introduced separately. Validated standalone and main-CMake builds, 33 sizing/selector tests, and lintrunner. Authored with OpenAI Codex.
Reject convolution and depthwise convolution dimensions, strides, and channel multipliers outside [1, 65535], and padding outside [0, 65535], before calling ESP-NN scratch-size queries. Vendor dispatch narrows these values to uint16; a zero or wrapped filter width can otherwise terminate Python with a divide-by-zero instead of raising an exception. Document the bounds and exercise invalid values and valid boundaries across the S3, RISC-V PIE, generic, and ANSI bindings. The sizing-only binding build, 161 scratch tests, and lintrunner passed. Authored with OpenAI Codex.
Enable the C++ exceptions and RTTI required by pybind11 when the root build disables them for the runtime. Exercise this configuration in CI by building scratch bindings through root CMake with size optimization enabled. Use the shared ESP-NN source fetch and ESPNN_LOCAL_PATH override, removing the separate download pin and local version checks. Authored with OpenAI Codex.
ESP operator lowering needs the scratch-size calculations for the selected device kernel without building or running ESP-NN kernels on the host. This adds optional bindings for all seven ESP-NN 1.5.0 scratch-size APIs: convolution, depthwise convolution, softmax, mean, hard-swish, batched fully connected, and logistic.
EspTargetandEspKernelModeselect S3, P4/S31 PIE, generic optimized, or ANSI queries. The pybind11 functions have typed parameters and named keyword arguments. CMake uses the delegate's shared ESP-NN fetch, with one default release tag and the sameESPNN_LOCAL_PATHoverride. Local checkouts require no version metadata. The root CMake size-optimized build retains the C++ exceptions and RTTI needed by pybind11, and CI exercises that configuration. The host modules link sizing code only; MSVC-style compiler frontends receive an explicit unsupported-toolchain error.The bindings check dimension bounds and intermediate arithmetic before entering vendor code, including combinations whose overflow would otherwise return a plausible positive size. Actual sizes still come from the vendor getters. Missing optional modules permit portable fallback; ABI failures and missing transitive dependencies surface as errors. CI requires all four profiles so absent extensions cannot turn the suite green through skips.
Review the selector and binding API first, then build/package integration and tests. Conv2d lowering and runtime scratch use remain in #25154.
Validation: standalone local-source, pinned fetched-source, and root-CMake sizing-only builds passed. All four size-optimized modules passed the 222 sizing/selector/bounds tests, and a combined delegate/scratch build passed three host interpreter tests. Default fetching and a local checkout without a version manifest both configured successfully; the missing-bindings negative control failed as intended. These tests also pass within the revised stack's 978-test Python suite. Scoped lint passed. Additional chip profiles have host sizing coverage only; wheel-install CI remains follow-up coverage.
Authored with OpenAI Codex.