Repository navigation
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/25154
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 PendingAs of commit f0ccd79 with merge base 351e938 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
c36b1f3 to
967de28
Compare
|
Claude finished @rascani's task in 47m 15s —— View job Re-review of Detailed reviewPR Review: #25154SummaryThis PR lowers Previous findings, re-checked against this revision
I couldn't run the tests here because Python execution needed approval in this job. The ESP-NN sources aren't in the checkout either, so claims about ESP-NN internals are marked low confidence. Code Quality
API Design
Thread Safety
Testing
RecommendationApprove Nothing is blocking. Two small fixes are worth folding in before merge:
The kernel geometry checks, the shared ESP-NN lock and the extra coverage can follow later in stack #25158. Review steps
|
5ae7977 to
c8a3bf3
Compare
c8a3bf3 to
472cb3b
Compare
472cb3b to
6adbe1f
Compare
|
@claude /pr-review Please re-review the current revision ( Scratch size-query ValueError now retains the portable FQ convolution before weighted constants are inserted. A regression using an actual rejected vendor dimension bound checks numerical fallback, serialization, and strict-export rejection. Please review the ordering, exception scope, and coverage. Focused convolution tests passed, and 969 combined host tests passed at the stack tip with all four sizing bindings rebuilt. A separate shared-FQ fallback issue for a single output channel producing nonconstant per-tensor qparams remains known and unchanged by this fix. |
|
Claude finished @rascani's task in 25m 3s —— View job Re-review of Detailed reviewPR Review: #25154SummaryThis PR lowers Previous findings (review of
I couldn't run the tests because Python execution needs approval in this job. The ESP-NN 1.5.0 sources aren't in the checkout, so claims about vendor internals are marked low confidence. Code Quality
Testing
API Design
Thread Safety
RecommendationApprove Nothing blocks merge. Worth folding in here:
The remaining open items can follow in stack #25158. Review steps
|
|
actual ci errors here |
Lower static groups=1, unit-dilation int8 convolution using the ESP-NN scratch-size bindings from the preceding commit. EspTarget and EspKernelMode select the query used to allocate a planned byte tensor; the runtime checks its size before setting ESP-NN's scratch pointer. Support constant per-channel weights, derived int32 bias, batches, rectangular kernels, stride, and padding. Unsupported calls or missing sizing bindings keep portable convolution. Keep the delegate and shared Fused Quant transforms unchanged. Validated 208 backend Python tests, all 24 Conv2d ESP32-S3 emulator tests, and lintrunner. Emulator cases cover repeated inference, undersized scratch rejection, ANSI zero scratch, and missing-binding fallback. Authored with OpenAI Codex.
Treat a sizing binding's bounds rejection as an unsupported convolution configuration. Query before inserting requantization constants so rejected calls remain available to portable decomposition without partial lowering state. Added a real sizing-bound regression that checks numerical fallback, serialization, and strict-export rejection. Validated 34 host convolution tests with freshly built sizing bindings. Authored with OpenAI Codex.
Keep checks that remove the S3 sizing binding or exercise its bounds explicitly on S3. Make the device fallback case remove sizing for whichever chip the CI job selects, preserving the target support introduced on main. Authored with OpenAI Codex.
Exercise selected-target scratch planning and serialization with compute coverage required. Supported convolutions retain their reported layout copies; missing sizing or unsupported bounds still fail strict export. Authored with OpenAI Codex.
Lower supported Fused Quant Conv2d calls to ESP-NN using the scratch-size API from #25157. Export inserts an explicit byte tensor whose storage and 16-byte-aligned offset are assigned by ordinary memory planning; the device checks buffer capacity before calling the selected kernel. The application supplies an appropriately aligned arena and serializes ESP-NN execution because the vendor scratch pointer is global.
Support covers static 4-D int8 inputs, constant per-output-channel symmetric int8 weights, optional derived int32 bias, groups=1, and unit dilation, including batches, rectangular kernels, stride, and padding. Unsupported configurations or unavailable sizing bindings retain portable convolution. The recipe and pass manager accept
EspTargetandEspKernelMode, including zero-byte scratch for generic or ANSI kernels. The tester defaults toESPRESSIF_TARGET; explicit target overrides apply to both scratch planning and firmware execution.Numerical preparation rejects reductions too long for its float32 error bound. Tests assert lowering before execution and check serialized scratch capacity, alignment, and non-overlap. The runner removes stale emulator output before export/build, and CI runs Python operator tests after building the sizing bindings.
Review lowering and allocation first, then the wrapper and shared dialect/implementation cases. Validation: Conv2d host tests pass, including selected-target scratch planning and S3 binding-fallback checks; the staged batch, staged no-bias, stride-remainder, and undersized-scratch cases passed on the optimized ESP32-S3 emulator. Scoped lint passed. Other chip profiles have host sizing/export coverage only.
Authored with OpenAI Codex.