ci: fix macOS PyTorch wheel cache key for branch-ref pins#19350
Open
rascani wants to merge 1 commit intopytorch:mainfrom
Open
ci: fix macOS PyTorch wheel cache key for branch-ref pins#19350rascani wants to merge 1 commit intopytorch:mainfrom
rascani wants to merge 1 commit intopytorch:mainfrom
Conversation
`install_pytorch_and_domains` constructs the cached-wheel URL using
`${TORCH_VERSION:0:7}`, which gives "release" when the pin is a
branch ref like `release/2.11`. The upload code uses the basename of
`dist/*.whl`, which is whatever PyTorch's setup.py wrote — always the
resolved commit hash (e.g. `+git70d99e9`). The two never match, so
every macOS run misses the cache and does a ~30-minute source build
even though the wheel for the current pin's HEAD is already in S3.
Resolve the hash via `git rev-parse --short=7 HEAD` after `git
checkout`, so download and upload agree. Commit-hash pins are
unchanged (the first 7 chars already equaled the resolved hash).
Authored with Claude Code.
meta-cla
Bot
added
the
CLA Signed
This PR needs a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install_pytorch_and_domainsconstructs the cached-wheel URL using${TORCH_VERSION:0:7}, which gives "release" when the pin is a branch ref likerelease/2.11. The upload code uses the basename ofdist/*.whl, which is whatever PyTorch's setup.py wrote — always the resolved commit hash (e.g.+git70d99e9). The two never match, so every macOS run misses the cache and does a ~30-minute source build even though the wheel for the current pin's HEAD is already in S3.Resolve the hash via
git rev-parse --short=7 HEADaftergit checkout, so download and upload agree. Commit-hash pins are unchanged (the first 7 chars already equaled the resolved hash).Authored with Claude Code.
Test plan
CI