[slimtensor] Add storage and device property getters to common_shims_slim #16991
+189
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request resolved: #16454 Add SlimTensor-based implementations of basic property getter AOTI shim functions: 1. `aoti_torch_get_data_ptr()` - Returns pointer to tensor data 2. `aoti_torch_get_sizes()` - Returns pointer to sizes array (SlimTensor stores int64_t directly) 3. `aoti_torch_get_strides()` - Returns pointer to strides array (SlimTensor stores int64_t directly) 4. `aoti_torch_get_dtype()` - Returns the scalar type as int32_t 5. `aoti_torch_get_dim()` - Returns the number of dimensions Key design: - Create a new common_shim_slim.h for working on new API while not impact the current pipeline. Will use common_shim_slim.{h/cpp} to replace current common_shim.{h/cpp} when everything has been set up. - Uses `#ifdef CUDA_AVAILABLE` conditional compilation to seperate the implementation between cuda backend and mps backend since SlimTensor hasn't have mps support yet. Will remove the branch once SlimTensor support mps. - Refactored to a header-only library so the caller's preprocessor flags determine which tensor type is used. This design supports both CUDA backend (SlimTensor) and MPS backend (ETensor) from a single library. ghstack-source-id: 336530252 @exported-using-ghexport Differential Revision: [D90126254](https://our.internmc.facebook.com/intern/diff/D90126254/)
…slim Pull Request resolved: #16455 Add storage and device property getter AOTI shim functions to the header-only common_shims_slim library: 1. `aoti_torch_get_storage_offset()` - Returns the storage offset (SlimTensor: real offset, ETensor: always 0) 2. `aoti_torch_get_storage_size()` - Returns storage size in bytes 3. `aoti_torch_get_device_type()` - Returns device type (SlimTensor: real type, ETensor: CPU=0) 4. `aoti_torch_get_device_index()` - Returns device index (SlimTensor: real index, ETensor: 0) ghstack-source-id: 336530255 @exported-using-ghexport Differential Revision: [D90126251](https://our.internmc.facebook.com/intern/diff/D90126251/)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16991
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit a2da091 with merge base 0006c83 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Gasoonjia
approved these changes
Jan 29, 2026
This PR needs a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #16455 by @Gasoonjia
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/97/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/97/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/96/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/97/orig
Differential Revision: D90126251
@diff-train-skip-merge