Skip to content

Guard Stride tl.assume #3924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Guard Stride tl.assume #3924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions fbgemm_gpu/experimental/gemm/triton_gemm/fp8_gemm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1190,6 +1190,14 @@ def persistent_grid(META):
if bias is not None:
raise AssertionError("bias is not supported in non-persistent kernel")
# pyre-ignore
enable_buffer_ops_assumes = (
a.stride(0) >= 0
and a.stride(1) >= 0
and b.stride(0) >= 0
and b.stride(1) >= 0
and c.stride(0) >= 0
and c.stride(1) >= 0
)
torch._library.capture_triton(_kernel_matmul_fp8_row_non_persistent)[grid](
a,
b,
Expand All @@ -1215,6 +1223,7 @@ def persistent_grid(META):
# GROUP_M=8,
# USE_BIAS=bias is not None,
AB_DTYPE=False,
ENABLE_BUFFER_OPS_ASSUMES=enable_buffer_ops_assumes,
)
elif use_warp_specialization:
assert has_warp_specialization
Expand Down Expand Up @@ -3363,6 +3372,7 @@ def _kernel_matmul_fp8_row_non_persistent(
SPLIT_K: tl.constexpr,
EVEN_K: tl.constexpr,
AB_DTYPE: tl.constexpr,
ENABLE_BUFFER_OPS_ASSUMES: tl.constexpr,
) -> None:
"""Matmul kernel of [M, K] @ [N, K] with row-wise scales

Expand Down Expand Up @@ -3397,15 +3407,16 @@ def _kernel_matmul_fp8_row_non_persistent(
EVEN_K (bool): Whether K is evenly divisible by BLOCK_K * SPLIT_K.
AB_DTYPE (bool): Wether to cast A and B to C.dtype before tensor core.
"""
tl.assume(M >= 0)
tl.assume(N >= 0)
tl.assume(K >= 0)
tl.assume(stride_am >= 0)
tl.assume(stride_ak >= 0)
tl.assume(stride_bn >= 0)
tl.assume(stride_bk >= 0)
tl.assume(stride_cm >= 0)
tl.assume(stride_cn >= 0)
if ENABLE_BUFFER_OPS_ASSUMES:
tl.assume(M >= 0)
tl.assume(N >= 0)
tl.assume(K >= 0)
tl.assume(stride_am >= 0)
tl.assume(stride_ak >= 0)
tl.assume(stride_bn >= 0)
tl.assume(stride_bk >= 0)
tl.assume(stride_cm >= 0)
tl.assume(stride_cn >= 0)
# Matrix multiplication.
pid = tl.program_id(0)
pid_z = tl.program_id(1)
Expand Down
Loading