-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard Stride tl.assume #3924
Open
njriasan
wants to merge
1
commit into
pytorch:main
Choose a base branch
from
njriasan:export-D72398678
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Guard Stride tl.assume #3924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was exported from Phabricator. Differential Revision: D72398678 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
njriasan
added a commit
to njriasan/FBGEMM
that referenced
this pull request
Apr 3, 2025
Summary: Guards the tl.assume values generated by the strides behind a non-negative requirement. This is not due to any regression, just a reviewer suggestion. Differential Revision: D72398678
a217887
to
22fa17b
Compare
njriasan
added a commit
to njriasan/FBGEMM
that referenced
this pull request
Apr 3, 2025
Summary: Guards the tl.assume values generated by the strides behind a non-negative requirement. This is not due to any regression, just a reviewer suggestion. Differential Revision: D72398678
22fa17b
to
3211fee
Compare
This pull request was exported from Phabricator. Differential Revision: D72398678 |
njriasan
added a commit
to njriasan/FBGEMM
that referenced
this pull request
Apr 3, 2025
Summary: Pull Request resolved: pytorch#3924 Guards the tl.assume values generated by the strides behind a non-negative requirement. This is not due to any regression, just a reviewer suggestion. Differential Revision: D72398678
3211fee
to
52197a0
Compare
Summary: X-link: facebookresearch/FBGEMM#1012 Pull Request resolved: pytorch#3924 Guards the tl.assume values generated by the strides behind a non-negative requirement. This is not due to any regression, just a reviewer suggestion. Differential Revision: D72398678
This pull request was exported from Phabricator. Differential Revision: D72398678 |
52197a0
to
63e77fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Guards the tl.assume values generated by the strides behind a non-negative requirement. This is not due to any regression, just a reviewer suggestion.
Differential Revision: D72398678