Skip to content

Fix instance comparison in AbsMax and AbsMin classes #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix instance comparison in AbsMax and AbsMin classes #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78dee18
Fix instance comparison in AbsMax and AbsMin classes
sunnynguyen-ai Sep 26, 2025
425cb9d
Fix IPv4 private IP detection with CIDR notation
sunnynguyen-ai Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/validators/_extremes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class AbsMax:

def __ge__(self, other: Any):
"""GreaterThanOrEqual."""
return other is not AbsMax
return not isinstance(other, AbsMax)


@total_ordering
Expand All @@ -44,4 +44,4 @@ class AbsMin:

def __le__(self, other: Any):
"""LessThanOrEqual."""
return other is not AbsMin
return not isinstance(other, AbsMin)
4 changes: 3 additions & 1 deletion src/validators/ip_address.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@ def ipv4(
if cidr:
if strict and value.count("/") != 1:
raise ValueError("IPv4 address was expected in CIDR notation")
return IPv4Network(value, strict=not host_bit) and _check_private_ip(value, private)
# Extract IP part for private check when using CIDR notation
ip_part = value.split('/')[0] if '/' in value else value
return IPv4Network(value, strict=not host_bit) and _check_private_ip(ip_part, private)
return IPv4Address(value) and _check_private_ip(value, private)
except (ValueError, AddressValueError, NetmaskValueError):
return False
Expand Down