Fix instance comparison in AbsMax and AbsMin classes #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed identity comparison (is not) to instance checking (isinstance) - Fixes incorrect behavior when comparing instances of same class
- Extract IP address part from CIDR notation before checking if private - Fixes validation of addresses like "192.168.1.0/24" with private parameter - Prevents incorrect private/public detection when subnet mask is included
|
I'm afraid, I do not see the need for change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
Fixed incorrect comparison logic in AbsMax and AbsMin classes.
Changes
other is not AbsMaxtonot isinstance(other, AbsMax)other is not AbsMintonot isinstance(other, AbsMin)Impact
between()validator works correctly with default parameters