Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move __name__ mangling to end of module #156

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

noahbkim
Copy link
Contributor

@noahbkim noahbkim commented Mar 7, 2025

Changing __name__ in the middle of the module causes subsequent definitions to have the mangled (and therefore incorrect) __module__, which causes a bad interaction with cloudpickle (which in turn needs to ensure pickled functions can be imported from their __module__). Moving the __name__ change to the end of the module satisfies the DeprecationWarning check while sidestepping the above.

@noahbkim noahbkim force-pushed the pickling-fix branch 3 times, most recently from bf6815d to c513420 Compare March 7, 2025 21:57
@noahbkim
Copy link
Contributor Author

noahbkim commented Mar 7, 2025

Ah, I see these CI failures are already addressed in #155, I'll rebase once that lands

@mikenerone
Copy link
Member

Ah, I see these CI failures are already addressed in #155, I'll rebase once that lands

@noahbkim I'm not clear on what's causing the unrelated CI failure in that PR (#155) (only for Python 3.12 on MacOS?!?), and haven't had time to dig into it. I'd welcome an extra set of eyes if you're willing.

@mikenerone
Copy link
Member

Given the MacOS testing failures that affected #155, and which got fixed externally (seems like a Mac test environment problem in GHA that was present for a couple of days), I re-ran the failed Mac test for this PR. Indeed, it succeeds.

@oremanj oremanj merged commit 8d6744b into python-trio:master Mar 17, 2025
48 of 49 checks passed
@trio-bot
Copy link

trio-bot bot commented Mar 17, 2025

Hey @noahbkim, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

  • Github will automatically subscribe you to notifications on all our repositories. (But you can unsubscribe again if you don't want the spam.)

  • You'll be able to help us manage issues (add labels, close them, etc.)

  • You'll be able to review and merge other people's pull requests

  • You'll get a [member] badge next to your name when participating in the Trio repos, and you'll have the option of adding your name to our member's page and putting our icon on your Github profile (details)

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants