Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix RaisesGroup(strict=...) in tests, removed in trio 0.27 #155

Merged
merged 3 commits into from
Mar 12, 2025

Conversation

mikenerone
Copy link
Member

@mikenerone mikenerone commented Mar 2, 2025

Trivial fix replacing RaisesGroup(strict=False) with RaisesGroup(flatten_subgroups=True) in tests (strict was deprecated in Trio 0.26 and removed in Trio 0.27 in October 2024).

Also fixes a couple of tiny docs-related issues that were breaking the docs build due to recent external changes, and thus failing CI:

  1. RTD now requires an explicit configuration setting specifying the config file.
  2. Sphinx no longer requires an explicit call to get_html_theme_path(), and in fact warns WARNING: Calling get_html_theme_path is deprecated. If you are calling it to define html_theme_path, you are safe to remove that code. (and CI treats warns as errors).

Fixes #154

@mikenerone mikenerone force-pushed the mikenerone/fix-tests-raisesgroup-strict branch from 1850a6b to d74158d Compare March 2, 2025 19:16
@mikenerone
Copy link
Member Author

I'm failing to grok why CI is failing for Python 3.12 under MacOS. I've run the tests that way locally and can't reproduce. @jakkdl or anyone else, any ideas?

@jakkdl
Copy link
Member

jakkdl commented Mar 6, 2025

I have no clue, @graingert do you have any ideas?

@graingert
Copy link
Member

I'm afk for a while, I usually debug this sort of thing using objgraph. You might need to use https://github.com/marketplace/actions/debugging-with-tmate if you can't repeat locally

@noahbkim
Copy link
Contributor

noahbkim commented Mar 9, 2025

Thinking this is spurious as I cannot reproduce locally on my MacBook with Python 3.12, have you tried rerunning the checks?

@jakkdl
Copy link
Member

jakkdl commented Mar 10, 2025

Thinking this is spurious as I cannot reproduce locally on my MacBook with Python 3.12, have you tried rerunning the checks?

2025-03-10T12:44:31,509049763+01:00
yeah 😕

@jakkdl
Copy link
Member

jakkdl commented Mar 10, 2025

but it's unrelated both to this and #156, so I think we can mark it xfail and try to address it in a separate PR

@mikenerone
Copy link
Member Author

mikenerone commented Mar 12, 2025

...I think we can mark it xfail and try to address it in a separate PR

If I just xfail it, the test will fail when running locally (i.e. because it succeeds where we're expecting a failure). Maybe I should rather skip it for Python 3.12/MacOS.

More fundamentally, I'm concerned that something really might have changed with recent Python 3.12, and the failure is somehow legitimate, and we might end up with a broken release next time if we forget to get to the bottom of this before then.

@mikenerone
Copy link
Member Author

Well, nevermind, whatever it was resolved itself. I've rerun the tests (again) twice today, and it passed both times. I would guess that "they" fixed something in the Python3.12/MacOS test environment.

@mikenerone mikenerone merged commit 42c9837 into master Mar 12, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failures with trio 0.27.0
4 participants