Skip to content

Fix python-flint build failure [full build] #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanking13 merged 8 commits into from
May 19, 2025
Merged

Fix python-flint build failure [full build] #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9cbd690
Fix `python-flint` build failure
agriyakhetarpal May 16, 2025
2bc8a96
Fix `python-flint` build failure [full build]
agriyakhetarpal May 16, 2025
e4b019e
Trigger CI again
agriyakhetarpal May 16, 2025
a04ef5c
Bump flint
agriyakhetarpal May 16, 2025
3e31655
Drop flint patch
agriyakhetarpal May 16, 2025
883ed2f
Set WASM target triplet
agriyakhetarpal May 16, 2025
a447263
Disable assembly codegen and pthread
agriyakhetarpal May 16, 2025
56aa092
`test_python_flint_tests` timing out on Chrome
agriyakhetarpal May 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions packages/flint/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
package:
name: flint
version: 3.0.1
version: 3.2.2
tag:
- library
- static_library
source:
url: https://github.com/flintlib/flint/releases/download/v3.0.1/flint-3.0.1.tar.gz
sha256: 7b311a00503a863881eb8177dbeb84322f29399f3d7d72f3b1a4c9ba1d5794b4
patches:
- patches/0001-Makefile.in-fix-handling-of-DESTDIR.patch
url: https://github.com/flintlib/flint/releases/download/v3.2.2/flint-3.2.2.tar.gz
sha256: 577d7729e4c2e79ca1e894ad2ce34bc73516a92f623d42562694817f888a17eb
requirements:
host:
- libgmp
Expand All @@ -23,7 +21,10 @@ build:
--disable-shared \
--prefix=${WASM_LIBRARY_DIR} \
--with-gmp=${WASM_LIBRARY_DIR} \
--with-mpfr=${WASM_LIBRARY_DIR}
--with-mpfr=${WASM_LIBRARY_DIR} \
--host=wasm32-unknown-emscripten \
--disable-assembly \
--disable-pthread
emmake make -j ${PYODIDE_JOBS:-3}
emmake make install
about:
Expand Down
108 changes: 0 additions & 108 deletions packages/flint/patches/0001-Makefile.in-fix-handling-of-DESTDIR.patch
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions packages/python-flint/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package:
name: python-flint
version: 0.6.0
version: 0.7.1
top-level:
- flint
requirements:
Expand All @@ -9,8 +9,8 @@ requirements:
- libgmp
- libmpfr
source:
url: https://files.pythonhosted.org/packages/16/3a/d129f056475191377a823efe9876656a81d563bb7463d0f8568ebee81ef6/python-flint-0.6.0.tar.gz
sha256: f829e00774534891b38de41bc511cf6c7d6d216544a6a84b92d9e1f159de0878
url: https://files.pythonhosted.org/packages/source/p/python_flint/python_flint-0.7.1.tar.gz
sha256: 8594cdbcba0c29503eefca76dfca37fe2388f11ee95c8d1f74e47006b97ce6d2
build:
cflags: |
-I$(WASM_LIBRARY_DIR)/include
Expand Down
2 changes: 1 addition & 1 deletion packages/python-flint/test_python_flint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def test_python_flint(selenium):
assert a.gcd(a * b) == a


@pytest.mark.xfail_browsers(firefox="times out")
@pytest.mark.xfail_browsers(firefox="times out", chrome="times out")
@run_in_pyodide(packages=["python-flint"])
def test_python_flint_tests(selenium):
from flint.test.__main__ import main
Expand Down
Loading