-
Notifications
You must be signed in to change notification settings - Fork 58
Fix python-flint build failure [full build]
#91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
So I think there's a bug here in |
python-flint build failurepython-flint build failure [full build]
|
Should we also allow full builds on labels and on commit messages? I didn't look too closely and I noticed that it applies only to the PR title. |
|
FLINT is definitely found, the error from the Meson logs is here: |
|
Okay, so The tests are still running, so we should be good to merge once they pass, or I'll have more things to do here :) |
|
Okay, the python-flint tests are passing but I don't see why the other failures don't show up in other PRs; these packages are not related to python-flint in any way. I'll debug them later today. |
ryanking13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Okay, the python-flint tests are passing but I don't see why the other failures don't show up in other PRs; these packages are not related to python-flint in any way. I'll debug them later today.
@agriyakhetarpal Those are because of a new Cython version. pyodide/pyodide#5626.
You can run ./tools/sync_packages.sh to apply the changes from the pyodide/pyodide repository. It may remove some changes like #90. So you'll cherry-pick some changes though.
|
I'll go ahead and merge this, so I can fix other cython related issues. Thanks @agriyakhetarpal! |
|
Thanks for the review and for getting to them before I could! :) |
For some reason
python-flintfailed onmain: https://github.com/pyodide/pyodide-recipes/actions/runs/15062463362/job/42340019530In pyodide/pyodide#5626, we pinned Cython<3.1, but this seems to be resolved as python-flint 0.7.1 (which is being updated to here) is now compatible with Cython 3.1.0a1.
This PR updates the versions of
python-flintand FLINT, and updates FLINT's build script for WASM compilation.