Skip to content

Bump rustworkx to 0.17.1 [full build] #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanking13 merged 4 commits into from
Sep 21, 2025
Merged

Bump rustworkx to 0.17.1 [full build] #316

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed5d195
Bump rustworkx to 0.17.1
IvanIsCoding Aug 13, 2025
f30f97d
Add rust-src component with rustup
IvanIsCoding Aug 14, 2025
fbdc31b
Merge branch 'main' into update-rustworkx-0171
ryanking13 Aug 19, 2025
37d46b9
Merge branch 'main' into update-rustworkx-0171
ryanking13 Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/rustworkx/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
package:
name: rustworkx
version: 0.17.0a3
version: 0.17.1
top-level:
- rustworkx
tag:
- rust
source:
url: https://github.com/IvanIsCoding/rustworkx/releases/download/v0.17.0a3/rustworkx-0.17.0a3.tar.gz
sha256: 8bd0c295134e2b0c03808d4e69428b41153849db6488839084a78793c337f191
url: https://github.com/Qiskit/rustworkx/archive/refs/tags/0.17.1.tar.gz
sha256: dc248da9cc364b81ac67f5d67b626ee3f03a1f6299f7a9b4d0a0501548715365
build:
script: export RUSTFLAGS="$RUSTFLAGS -C target-feature=+atomics,+bulk-memory,+mutable-globals"
script: |
rustup component add rust-src
Copy link
Member

@ryanking13 ryanking13 Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoodmane WDYT about this? I am not sure if it is a good idea for individual package to run this command, as it will make global effect (AFAIK).

Copy link
Contributor Author

@IvanIsCoding IvanIsCoding Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we could move it to the original rustup setup, it would be best.

I also think rust-src has no effect? Unless users pass the stable flag to recompile std

Copy link
Member

@ryanking13 ryanking13 Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoodmane Do you think that rustup component add rust-src can overwrite the custom stdlib that we built with wasm-exception enabled?

Rust build toolchain is always confusing to me...

Copy link
Member

@hoodmane hoodmane Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is okay. It would also be fine to add it as part of our normal setup. But that is a pyodide-build change, so I think we can merge this as-is (if it otherwise looks good) and move it into pyodide-build later.

Copy link
Member

@ryanking13 ryanking13 Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay. The rustup component add rust-src downloads the source, not the compiled binary... so it should be unrelated to it. Thanks for the response.

export RUSTFLAGS="$RUSTFLAGS -C target-feature=+atomics,+bulk-memory,+mutable-globals"
requirements:
executable:
- rustup
Expand Down
Loading