Skip to content

Conversation

@IvanIsCoding
Copy link
Contributor

Follow up to #90

rustworkx now supports Pyodide in a released version! Previously, it used an alpha version from my personal repository.

Thanks again for providing pyodide-build and all the recipes!

@IvanIsCoding IvanIsCoding changed the title Bump rustworkx to 0.17.1 [WIP] Bump rustworkx to 0.17.1 Aug 13, 2025
@IvanIsCoding
Copy link
Contributor Author

I need to investigate the compilation failure, my apologies

@ryanking13
Copy link
Member

No worries, please let us know when you are stuck.

We also have some Rust-related information in our docs. Most of them should be automatically handled inside pyodide-build (as we already build the alpha version of rustworkx), but it might be helpful in some cases.

@github-actions
Copy link
Contributor

Package Build Results

Total packages built: 28
Total build time: 0:03:26

Package Build Times (click to expand)
Package Build Time
rustworkx 3m 19s
libopenssl 3m 15s
sqlite3 1m 44s
liblzma 1m 27s
test 24s
regex 18s
ssl 8s
hashlib 6s
pydoc_data 5s
lzma 5s
pydecimal 4s
MarkupSafe 4s
atomicwrites 3s
pytz 1s
attrs 1s
py 1s
tblib 1s
setuptools 1s
more-itertools 1s
pyparsing 1s
micropip 1s
pytest 1s
Jinja2 1s
exceptiongroup 0s
pluggy 0s
pytest-asyncio 0s
iniconfig 0s
six 0s

Longest build: rustworkx (3m 19s)
Packages built in more than 10 minutes: 0

@IvanIsCoding IvanIsCoding changed the title [WIP] Bump rustworkx to 0.17.1 Bump rustworkx to 0.17.1 Aug 14, 2025
@IvanIsCoding
Copy link
Contributor Author

There was nothing wrong with the library code per se, but right now rustworkx needs rust-src because of -C target-feature=+atomics,+bulk-memory,+mutable-globals" in the RUSTFLAGS.

A small change to script fixed the compilation issue.

build:
script: export RUSTFLAGS="$RUSTFLAGS -C target-feature=+atomics,+bulk-memory,+mutable-globals"
script: |
rustup component add rust-src
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoodmane WDYT about this? I am not sure if it is a good idea for individual package to run this command, as it will make global effect (AFAIK).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we could move it to the original rustup setup, it would be best.

I also think rust-src has no effect? Unless users pass the stable flag to recompile std

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoodmane Do you think that rustup component add rust-src can overwrite the custom stdlib that we built with wasm-exception enabled?

Rust build toolchain is always confusing to me...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is okay. It would also be fine to add it as part of our normal setup. But that is a pyodide-build change, so I think we can merge this as-is (if it otherwise looks good) and move it into pyodide-build later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay. The rustup component add rust-src downloads the source, not the compiled binary... so it should be unrelated to it. Thanks for the response.

@ryanking13 ryanking13 changed the title Bump rustworkx to 0.17.1 Bump rustworkx to 0.17.1 [full build] Aug 19, 2025
Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Sorry for the delayed review!

@ryanking13 ryanking13 merged commit 935964a into pyodide:main Sep 21, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants