Workaround for the Legendre function bug in scipy #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally posted by @JohKem the GH issue on the bug: scipy/scipy#23101
ahms5
reviewed
Sep 17, 2025
Comment on lines
398
to
400
| # squeeze required because the legendre function introduced in scipy 1.15 | ||
| # returns a 2D array, whereas the previous function `lpmn` returned a 1D | ||
| # array |
There was a problem hiding this comment.
Suggested change
| # squeeze required because the legendre function introduced in scipy 1.15 | |
| # returns a 2D array, whereas the previous function `lpmn` returned a 1D | |
| # array | |
| # squeeze required because the legendre function introduced in scipy 1.15 | |
| # returns a 2D array, whereas the previous function `lpmn` returned a 1D | |
| # array |
|
@mberz , @f-brinkmann: This PR and #143 address the same issue. #143 proposes a different solution, and adds tests. Should both PRs be merged or can one be closed? |
|
@sikersten |
|
This PR would merge into #143 |
f-brinkmann
approved these changes
Sep 18, 2025
There was a problem hiding this comment.
Thx. Also note that #143 is already merged into this. So we know that the workaround is working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for the bug encountered in #143
We can merge this in case the original issue does not get resolved in time