-
Notifications
You must be signed in to change notification settings - Fork 4
Deprecate scipy Legendre function #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care. the failing test is really annoying^^
I'm note sure about every detail, otherwise seems to be fine
| The argument as an array | ||
| cs_phase : bool, optional | ||
| Whether to use include the Condon-Shotley phase term (-1)^m or not | ||
| Whether to include the Condon-Shotley phase term (-1)^m or not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it requires a certain scipy version, we should add it to the pyproject.toml
It scheduled for scipy 1.17, but there hasn't been much action on the issue. I added a todo to the top so we don't forget. |
|
I'm not expecting that this will be solved in time for the next release of spharpy. |
|
There's an update on the respective scipy issue, let's wait for further updates here scipy/scipy#23101 |
Changes proposed in this pull request:
Note the following: I think the tests are failing due to an error in scipy scipy/scipy#23101
accoc_legendreinstead oflpmnwhich will be deprecated in scipy 1.17To Do