Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use type applications for Proxy #1235

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Use type applications for Proxy #1235

merged 3 commits into from
Jun 24, 2024

Conversation

f-f
Copy link
Member

@f-f f-f commented Jun 24, 2024

No description provided.

@f-f
Copy link
Member Author

f-f commented Jun 24, 2024

@cakekindel I merged the previous PR as it looked like it passed tests, but it doesn't - there was a stray Spec.focus that was preventing other tests from running - I removed it in this PR, and it looks like we still have the issue with windows

@cakekindel
Copy link
Contributor

Oh my goodness I'm so sorry

@f-f
Copy link
Member Author

f-f commented Jun 24, 2024

No worries, it's completely okay! 🙂 Do you have an idea on how to patch it up? If not I'll try to find a block of time sometime in the next days to look at it

@f-f f-f changed the title Use type applications Use type applications for Proxy Jun 24, 2024
@f-f f-f merged commit a9a3623 into master Jun 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants