fix: gitignoring glob behavior introduced in #1234 #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakekindel
changed the title
cakekindel
changed the title
|
opening this PR now so I can run against the windows CI container |
cakekindel
changed the title
|
I was able to reproduce with wine actually, should have a fix soon |
cakekindel
commented
Jun 24, 2024
| @@ -49,7 +49,7 @@ gitignoreGlob base = | |||
| ( \line -> do | |||
| let | |||
| resolve a = Path.concat [ base, a ] | |||
| pat a = resolve $ unpackPattern a | |||
| pat a = withForwardSlashes $ resolve $ unpackPattern a | |||
There was a problem hiding this comment.
🫠
Path.concat ["foo\\bar", "**"] == "foo\\bar\\**"
\** and /** are very different.
cakekindel
commented
Jun 24, 2024
|
|
||
| Spec.it "is stacksafe" \p -> do | ||
| hugeGitignore <- liftEffect $ intercalate "\n" <$> randomSample' 10000 (resize 4 $ genAlphaLowercaseString) |
There was a problem hiding this comment.
this would sometimes randomly generate left which would fail the test 😁
cakekindel
changed the title
|
@f-f this is ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1235