Skip to content

Conversation

@atharvasune
Copy link

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • tests pass -- see README.md for how to run them
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request are descriptively named
  • if possible, multiple commits squashed if they're smaller changes
  • reviewed/confirmed/tested by another contributor or maintainer

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

Please alert developers on [email protected] when your request is ready or if you need assistance.

Thanks!

@atharvasune atharvasune marked this pull request as ready for review September 13, 2019 16:07
@atharvasune
Copy link
Author

@sidntrivedi012 hi i made some changes, could you have a look at it?

Copy link
Member

@sidntrivedi012 sidntrivedi012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. But you could have made the commits of the changes to #130 itself.

Also, it's a good practice to commit from a different branch other than the main/master branch.

/cc: @jywarren PTAL.

@atharvasune
Copy link
Author

atharvasune commented Sep 14, 2019

oh okay thanks for the advice (newbie mistake 😅 . So should i make another commit to #130 or let it be? @sidntrivedi012

@sidntrivedi012
Copy link
Member

@atharvasune For now, you can close that PR. We can carry the work here. Thanks.

@atharvasune
Copy link
Author

Okay Thanks

@sidntrivedi012 sidntrivedi012 mentioned this pull request Sep 14, 2019
5 tasks
@atharvasune atharvasune reopened this Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants