Skip to content

Conversation

@atharvasune
Copy link

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • tests pass -- see README.md for how to run them
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request are descriptively named
  • if possible, multiple commits squashed if they're smaller changes
  • reviewed/confirmed/tested by another contributor or maintainer

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

Please alert developers on [email protected] when your request is ready or if you need assistance.

Thanks!

@welcome
Copy link

welcome bot commented Sep 13, 2019

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@atharvasune
Copy link
Author

HI, I am new to this, can anyone help me out with this, the review required part. What do i do now ?

@atharvasune
Copy link
Author

@sidntrivedi012 ?

Copy link
Member

@sidntrivedi012 sidntrivedi012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atharvasune You can refer the directory structure and the way template is made here - https://github.com/publiclab/plots2/tree/master/.github .

Thanks.

@sidntrivedi012
Copy link
Member

HI, I am new to this, can anyone help me out with this, the review required part. What do i do now ?

Try referring to the above link and put the Issue template in .github folder as we have implemented in plots2 repository.

@atharvasune atharvasune mentioned this pull request Sep 14, 2019
5 tasks
@sidntrivedi012
Copy link
Member

@atharvasune I guess you closed the wrong PR. Maybe you can close this one and we can carry out this work at #131. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants