-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[BUG] Lombok Tests Failing #3948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rename file (Part 1) Rename file (Part 2)
I noticed when building the tests using javac6 locally, the Terminal Output:
|
Rename file (Part 1) Rename file (Part 2)
It seems that the CI checks here are happy now. Let me know if there is anything I may have missed and I'll get it fixed asap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the tests 👍
- Please add yourself to the AUTHORS file
- Instead of adding
@SuppressWarnings
everywhere it is also possible to add a.messages
file for a test. Our test system compares the generated messages with this file and the test passes if the content matches. Using these files would lead to a smaller and simpler PR but your approach is fine too, just want to let you know for your next PR :)
Initially discovered on PR #3945, some unit tests unexpectedly started to fail due to the deprecation of
AccessLevel.MODULE
. This PR attempts to fix these tests and any others along the way. Right now, the failing tests for the various@Log
annotations new access level feature are passing locally. I'm still searching for if any other annotations are unexpectedly failing tests.