-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[BUG] Transient properties in classes with @Jacksonized @Accessors(fluent=true) get serialized #3945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The test for this specific bug-fix seems to be passing however the CI test checks are failing due to the deprecation of
And that one of the tests
I'll work on a PR to fix this. |
It sounds like a good idea to me, but as neither I nor Roel are all that familiar with Jackson, we'd defer to @janrieke 's wisdom. The failures of the test actions appear to be down to something wonky with how @liampace 's at this point integrated into |
@rzwitserloot |
This reverts commit 3a49c0a.
5259a26
to
7aba7cf
Compare
After the successful merging of PR #3948, this feature is now ready to be reviewed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just i small suggestion for test coverage improvement.
This pull request is related to Issue #3936.
Currently the
@Jacksonized
annotation mistakenly applies@JsonProperty
to transient fields. The new behavior has@Jacksonized
explicitly apply@JsonIgnore
to all transient fields.For example the following sample code:
would be equivalent to: