Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for invalid listen scheme #139

Merged
merged 3 commits into from
Mar 16, 2020
Merged

Add test for invalid listen scheme #139

merged 3 commits into from
Mar 16, 2020

Conversation

Ichimonji10
Copy link
Contributor

No description provided.

@Ichimonji10
Copy link
Contributor Author

This PR also originally included ansible/receptor#93 (comment), but that test is currently failing, and it doesn't even assert correct behaviour, so it seems a bit odd to add right now.

@Ichimonji10
Copy link
Contributor Author

Ichimonji10 commented Feb 18, 2020 •
edited
Loading

The new test introduced by this PR is failing, and I don't know why. I can't reproduce the failure locally.

Quite a few tests are failing, and I can reproduce locally, even without this PR. Very annoying.

@ansible-zuul
Copy link
Contributor

ansible-zuul bot commented Feb 25, 2020

Build succeeded.

@Ichimonji10
Copy link
Contributor Author

Rebased and added a second commit which tests #138.

elyezer
elyezer approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@elyezer elyezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ichimonji10 Ichimonji10 mentioned this pull request Mar 11, 2020
Merged
@Ichimonji10
Copy link
Contributor Author

Rebased, and added tests for ansible/receptor#153

@Ichimonji10 Ichimonji10 mentioned this pull request Mar 13, 2020
Closed
@Ichimonji10
Copy link
Contributor Author

BTW the automated tests added by this PR currently pass very consistently against devel. I don't recall the last time I've seen any of them fail, if ever.

Ichimonji10 referenced this pull request in project-receptor/affinity Mar 16, 2020
@Ichimonji10
Return listen_port of 8888 by default
42bcbe1 
This is useful in cases where the listen string lacks a port, like:

    receptor://127.0.0.1

This change will ensure that the `listen_port` method better adheres to
its signature (by more consistently returning an int) and simplify
certain tests, e.g. by dropping the `_wait_for_conns` method added in
ansible/receptor#139
@Ichimonji10
Copy link
Contributor Author

Dropped the _wait_for_conns method added by the second commit, as project-receptor/affinity#35 makes it unnecessary. Tests still pass against the devel branch.

@matburt matburt added the gate Gate PR in Zuul CI label Mar 16, 2020
@ansible-zuul ansible-zuul bot merged commit 20acb2c into project-receptor:devel Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elyezer elyezer elyezer approved these changes

@matburt matburt matburt approved these changes

Assignees
No one assigned
Labels
gate Gate PR in Zuul CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ichimonji10 @elyezer @matburt