Merge pull request #139 from Ichimonji10/test-ports

Add test for invalid listen scheme

Reviewed-by: https://github.com/apps/ansible-zuul

Author: ansible-zuul[bot]

Diff for: poetry.lock

@@ -30,6 +30,7 @@ receptor-affinity = { git = "https://github.com/project-receptor/affinity.git" }
 tox = "^3.14.5"
 yamllint = "^1.20.0"
 black = "^19.10b0"
+psutil = "^5.7.0"
 
 [tool.poetry.scripts]
 receptor = 'receptor.__main__:main'

Diff for: pyproject.toml

@@ -0,0 +1,77 @@
+"""Test port binding logic."""
+from uuid import uuid4
+
+import psutil
+import pytest
+from receptor_affinity import utils
+from receptor_affinity.exceptions import NodeUnavailableError
+from receptor_affinity.mesh import Node
+
+
+def test_invalid_listen_scheme():
+    """Start a node, and give it a listen address with an invalid scheme.
+
+    The node should fail to start. See `receptor #93`_.
+
+    .. NOTE:: This test should be extended to check that a traceback isn't printed to stdout or
+        stderr.
+
+    .. _receptor #93: https://github.com/project-receptor/receptor/issues/93
+    """
+    node = Node(str(uuid4()), listen=f'harglebargle://127.0.0.1:{utils.random_port()}')
+    with pytest.raises(NodeUnavailableError):
+        node.start()
+
+
+def test_listen_fragment():
+    """Start a node, and give it a listen address with a fragment.
+
+    The node should fail to start. See `receptor #153`_.
+
+    .. _receptor #153: https://github.com/project-receptor/receptor/issues/153
+    """
+    node = Node(str(uuid4()), listen=f'receptor://127.0.0.1:{utils.random_port()}#frag')
+    with pytest.raises(NodeUnavailableError):
+        node.start()
+
+
+def test_listen_path():
+    """Start a node, and give it a listen address with a path.
+
+    The node should fail to start. See `receptor #153`_.
+
+    .. _receptor #153: https://github.com/project-receptor/receptor/issues/153
+    """
+    node = Node(str(uuid4()), listen=f'receptor://127.0.0.1:{utils.random_port()}/path')
+    with pytest.raises(NodeUnavailableError):
+        node.start()
+
+
+def test_listen_query():
+    """Start a node, and give it a listen address with a query.
+
+    The node should fail to start. See `receptor #153`_.
+
+    .. _receptor #153: https://github.com/project-receptor/receptor/issues/153
+    """
+    node = Node(str(uuid4()), listen=f'receptor://127.0.0.1:{utils.random_port()}?key=val')
+    with pytest.raises(NodeUnavailableError):
+        node.start()
+
+
+def test_no_port_given():
+    """Start a node, and don't specify a port on which to listen.
+
+    Assert that it listens on port 8888. Older versions of receptor would listen on a random port.
+    See: `receptor #138`_.
+
+    .. _receptor #138: https://github.com/project-receptor/receptor/issues/138
+    """
+    node = Node(str(uuid4()), listen=f'receptor://127.0.0.1')
+    node.start()
+    try:
+        conns = psutil.Process(node.pid).connections()
+        assert len(conns) == 1
+        assert conns[0].laddr.port == 8888
+    finally:
+        node.stop()