Skip to content

Build wisp from main HEAD (d96bd0e) as 0.5.10:1 test build - #17

Closed
wksantiago wants to merge 8 commits into
masterfrom
test-build-main-head
Closed

Build wisp from main HEAD (d96bd0e) as 0.5.10:1 test build#17
wksantiago wants to merge 8 commits into
masterfrom
test-build-main-head

Conversation

@wksantiago

@wksantiago wksantiago commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Documentation
    • Updated the app’s current version information.
    • Refreshed release notes to reflect the latest upstream test build and included changes.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The Dockerfile's WISP_VERSION and WISP_COMMIT build arguments are updated to pin a new commit from main, and startos/versions/current.ts bumps the current version to 0.5.10:1 with updated release notes describing the test build.

Changes

Dependency pin and version bump

Layer / File(s) Summary
Wisp dependency pin update
Dockerfile
WISP_VERSION changed from v0.5.5 to main, and WISP_COMMIT updated to a new pinned commit hash used for checkout verification.
Version metadata bump
startos/versions/current.ts
current VersionInfo version updated from 0.5.5:0 to 0.5.10:1, and releaseNotes.en_US replaced with new text describing the test build.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • privkeyio/wisp-startos#4: Same pattern of updating Dockerfile's WISP_VERSION/WISP_COMMIT alongside version metadata bump in current.ts.
  • privkeyio/wisp-startos#7: Same pattern of updating the wisp dependency pin and bumping current.ts version/release notes.

Suggested reviewers: kwsantiago

Poem

A hop, a skip, a new commit hash,
"main" now guides the wisp-y stash.
Version ten-point-ten takes the stage,
release notes fresh on a brand new page.
Thump-thump, the build is snug and tight! 🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: building wisp from main HEAD as a 0.5.10:1 test build.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test-build-main-head

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@wksantiago

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Dockerfile`:
- Around line 26-30: The Dockerfile pin is inconsistent with the documented “tag
+ commit” contract because WISP_VERSION is set to main, which is a moving branch
rather than a fixed release ref. Update the pin in the Dockerfile so
WISP_VERSION points to a stable tag or exact ref that matches WISP_COMMIT, and
keep the existing guard semantics in sync with the clone step used for
WISP_VERSION. If this is meant to be a temporary test build, add a clear comment
near the WISP_VERSION/WISP_COMMIT args explaining that intent.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 078cad64-0898-4084-80bd-a1c798769849

📥 Commits

Reviewing files that changed from the base of the PR and between b9072fa and 93b9c35.

📒 Files selected for processing (2)
  • Dockerfile
  • startos/versions/current.ts

Comment thread Dockerfile
Comment on lines 26 to +30
# Pinned to the latest upstream release. Bump WISP_VERSION and WISP_COMMIT to
# update (see UPDATING.md). WISP_COMMIT is the immutable commit the tag points
# to; the guard below fails the build if the tag is ever re-pointed.
ARG WISP_VERSION=v0.5.5
ARG WISP_COMMIT=76a3261369ff4a2b5dedb778e8b1d42184800ea4
ARG WISP_VERSION=main
ARG WISP_COMMIT=d96bd0e036308e73922fa5e06b20394115ca0883

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

Pinning to main branch instead of a tag breaks the documented pin contract.

WISP_VERSION=main is a moving branch, not a release tag, but the comment above (unchanged) still says "set ARG WISP_VERSION to the new tag (e.g. v0.3.0) and ARG WISP_COMMIT to the commit that tag points to" and the in-file comment claims this is "Pinned to the latest upstream release" with a guard against "the tag ever re-pointed" — there is no tag here. Since the clone uses --branch ${WISP_VERSION} --depth 1, it only fetches the current tip of main; as soon as upstream main advances past d96bd0e, any rebuild will hard-fail the SHA guard (not just on a force-push/re-point). If this is intentionally a transient test build (per PR title), consider adding a comment clarifying that, or better, use a lightweight tag/ref that stays fixed to this exact commit so the guard's semantics match reality and the build doesn't silently break for anyone re-running it later.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Dockerfile` around lines 26 - 30, The Dockerfile pin is inconsistent with the
documented “tag + commit” contract because WISP_VERSION is set to main, which is
a moving branch rather than a fixed release ref. Update the pin in the
Dockerfile so WISP_VERSION points to a stable tag or exact ref that matches
WISP_COMMIT, and keep the existing guard semantics in sync with the clone step
used for WISP_VERSION. If this is meant to be a temporary test build, add a
clear comment near the WISP_VERSION/WISP_COMMIT args explaining that intent.

@wksantiago wksantiago closed this Jul 7, 2026
@wksantiago
wksantiago deleted the test-build-main-head branch July 7, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants