Build wisp from main HEAD (d96bd0e) as 0.5.10:1 test build - #17
Build wisp from main HEAD (d96bd0e) as 0.5.10:1 test build#17wksantiago wants to merge 8 commits into
Conversation
Update wisp to v0.5.6 (429/503 on WS upgrade connection-limit rejection)
Update wisp to v0.5.7 (shutdown use-after-free fix)
Update wisp to v0.5.9 (churn + shutdown crash fixes)
WalkthroughThe Dockerfile's ChangesDependency pin and version bump
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Dockerfile`:
- Around line 26-30: The Dockerfile pin is inconsistent with the documented “tag
+ commit” contract because WISP_VERSION is set to main, which is a moving branch
rather than a fixed release ref. Update the pin in the Dockerfile so
WISP_VERSION points to a stable tag or exact ref that matches WISP_COMMIT, and
keep the existing guard semantics in sync with the clone step used for
WISP_VERSION. If this is meant to be a temporary test build, add a clear comment
near the WISP_VERSION/WISP_COMMIT args explaining that intent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 078cad64-0898-4084-80bd-a1c798769849
📒 Files selected for processing (2)
Dockerfilestartos/versions/current.ts
| # Pinned to the latest upstream release. Bump WISP_VERSION and WISP_COMMIT to | ||
| # update (see UPDATING.md). WISP_COMMIT is the immutable commit the tag points | ||
| # to; the guard below fails the build if the tag is ever re-pointed. | ||
| ARG WISP_VERSION=v0.5.5 | ||
| ARG WISP_COMMIT=76a3261369ff4a2b5dedb778e8b1d42184800ea4 | ||
| ARG WISP_VERSION=main | ||
| ARG WISP_COMMIT=d96bd0e036308e73922fa5e06b20394115ca0883 |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Pinning to main branch instead of a tag breaks the documented pin contract.
WISP_VERSION=main is a moving branch, not a release tag, but the comment above (unchanged) still says "set ARG WISP_VERSION to the new tag (e.g. v0.3.0) and ARG WISP_COMMIT to the commit that tag points to" and the in-file comment claims this is "Pinned to the latest upstream release" with a guard against "the tag ever re-pointed" — there is no tag here. Since the clone uses --branch ${WISP_VERSION} --depth 1, it only fetches the current tip of main; as soon as upstream main advances past d96bd0e, any rebuild will hard-fail the SHA guard (not just on a force-push/re-point). If this is intentionally a transient test build (per PR title), consider adding a comment clarifying that, or better, use a lightweight tag/ref that stays fixed to this exact commit so the guard's semantics match reality and the build doesn't silently break for anyone re-running it later.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Dockerfile` around lines 26 - 30, The Dockerfile pin is inconsistent with the
documented “tag + commit” contract because WISP_VERSION is set to main, which is
a moving branch rather than a fixed release ref. Update the pin in the
Dockerfile so WISP_VERSION points to a stable tag or exact ref that matches
WISP_COMMIT, and keep the existing guard semantics in sync with the clone step
used for WISP_VERSION. If this is meant to be a temporary test build, add a
clear comment near the WISP_VERSION/WISP_COMMIT args explaining that intent.
Summary by CodeRabbit