Skip to content

Build wisp from main HEAD (d96bd0e) as 0.5.10:1 test build #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wksantiago wants to merge 8 commits into from
Closed

Build wisp from main HEAD (d96bd0e) as 0.5.10:1 test build #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4ed9908
Update wisp to v0.5.6 (429/503 on WS upgrade connection-limit rejection)
kwsantiago Jun 26, 2026
f892de9
Merge pull request #2 from privkeyio/update-wisp-v0.5.6
MattDHill Jun 26, 2026
4a9c4b2
Update wisp to v0.5.7 (shutdown use-after-free fix)
kwsantiago Jun 27, 2026
7924a4a
Merge pull request #3 from privkeyio/update-wisp-v0.5.7
MattDHill Jun 28, 2026
1778ea7
Update wisp to v0.5.9 (churn + shutdown crash fixes; folds in v0.5.8)
kwsantiago Jun 29, 2026
be897c7
Merge pull request #5 from privkeyio/update-wisp-v0.5.9
MattDHill Jun 29, 2026
a519daa
Update wisp to v0.5.10 (build against upstream http.zig; drop fork)
kwsantiago Jul 1, 2026
93b9c35
Build wisp from main HEAD (d96bd0e) as 0.5.10:1 test build
wksantiago Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ RUN case "${TARGETARCH}" in \
# Pinned to the latest upstream release. Bump WISP_VERSION and WISP_COMMIT to
# update (see UPDATING.md). WISP_COMMIT is the immutable commit the tag points
# to; the guard below fails the build if the tag is ever re-pointed.
ARG WISP_VERSION=v0.5.5
ARG WISP_COMMIT=76a3261369ff4a2b5dedb778e8b1d42184800ea4
ARG WISP_VERSION=main
ARG WISP_COMMIT=d96bd0e036308e73922fa5e06b20394115ca0883
Comment on lines 26 to +30

@coderabbitai coderabbitai Bot Jul 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Stale comment: no longer describes a tag-based pin.

The comment above still says "Pinned to the latest upstream release" and references "the guard below fails the build if the tag is ever re-pointed", but WISP_VERSION is now main (a mutable branch), not a release tag. Please update the comment to reflect that this is a temporary test-build pin to a specific commit on main, not a release tag.

📝 Suggested comment update 
-# Pinned to the latest upstream release. Bump WISP_VERSION and WISP_COMMIT to
-# update (see UPDATING.md). WISP_COMMIT is the immutable commit the tag points
-# to; the guard below fails the build if the tag is ever re-pointed.
+# TEST BUILD: pinned to a specific commit on main (past the v0.5.10 tag).
+# Bump WISP_VERSION and WISP_COMMIT to update (see UPDATING.md). The guard
+# below fails the build if the branch tip no longer matches WISP_COMMIT.
 ARG WISP_VERSION=main
 ARG WISP_COMMIT=d96bd0e036308e73922fa5e06b20394115ca0883
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Pinned to the latest upstream release. Bump WISP_VERSION and WISP_COMMIT to
# update (see UPDATING.md). WISP_COMMIT is the immutable commit the tag points
# to; the guard below fails the build if the tag is ever re-pointed.
ARG WISP_VERSION=v0.5.5
ARG WISP_COMMIT=76a3261369ff4a2b5dedb778e8b1d42184800ea4
ARG WISP_VERSION=main
ARG WISP_COMMIT=d96bd0e036308e73922fa5e06b20394115ca0883
# TEST BUILD: pinned to a specific commit on main (past the v0.5.10 tag).
# Bump WISP_VERSION and WISP_COMMIT to update (see UPDATING.md). The guard
# below fails the build if the branch tip no longer matches WISP_COMMIT.
ARG WISP_VERSION=main
ARG WISP_COMMIT=d96bd0e036308e73922fa5e06b20394115ca0883
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Dockerfile` around lines 26 - 30, Update the stale Dockerfile comment above
WISP_VERSION and WISP_COMMIT so it matches the current setup: this is no longer
a release-tag pin, but a temporary test-build pin to a specific commit on main.
In the Dockerfile, adjust the wording near the ARG WISP_VERSION and ARG
WISP_COMMIT declarations to remove references to “latest upstream release” and
the tag re-point guard, and instead describe the mutable branch plus
commit-based pinning accurately.

RUN git clone --branch ${WISP_VERSION} --depth 1 https://github.com/privkeyio/wisp.git /src && \
HEAD_SHA="$(git -C /src rev-parse HEAD)" && \
if [ "${HEAD_SHA}" != "${WISP_COMMIT}" ]; then \
Expand Down
4 changes: 2 additions & 2 deletions startos/versions/current.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { IMPOSSIBLE, VersionInfo } from '@start9labs/start-sdk'

export const current = VersionInfo.of({
version: '0.5.5:0',
version: '0.5.10:1',
releaseNotes: {
en_US:
'Updates wisp to v0.5.5. No behavior change from v0.5.4: wisp now builds against the upstream http.zig and websocket.zig libraries instead of temporary forks, since all of its fixes have been merged upstream. Carries forward every prior fix: the inbound-worker crash fix, crash-safe storage, stable Spider upstream connections, no per-IP cap behind the StartOS proxy, and the diagnosable (ReleaseSafe) build.',
'Test build: wisp built from upstream main HEAD (d96bd0e) past the v0.5.10 tag — includes connection reaping + SO_KEEPALIVE (#136), idle-close slot reclaim (#133), spider staleness watchdog (#132), and shutdown-aware spider bootstrap (#137).',
},
migrations: {
up: async ({ effects }) => {},
Expand Down
Loading