Skip to content

Build wisp from main HEAD (d96bd0e) as 0.5.10:1 test build - #16

Closed
wksantiago wants to merge 8 commits into
masterfrom
update-wisp-v0.5.10
Closed

Build wisp from main HEAD (d96bd0e) as 0.5.10:1 test build#16
wksantiago wants to merge 8 commits into
masterfrom
update-wisp-v0.5.10

Conversation

@wksantiago

@wksantiago wksantiago commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated the app’s reported version to a newer build.
    • Refreshed the release notes to describe the latest test build and included upstream reference details.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

This PR updates the pinned wisp build source in the Dockerfile from v0.5.5 to main at a new commit SHA, and bumps the StartOS current version metadata from 0.5.5:0 to 0.5.10:1 with updated release notes referencing the new upstream commit.

Changes

Wisp Version Bump

Layer / File(s) Summary
Update build pin and version metadata
Dockerfile, startos/versions/current.ts
WISP_VERSION/WISP_COMMIT ARGs updated to target main at a new commit SHA; current version bumped to 0.5.10:1 with updated release notes.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Poem

A hop, a skip, a fresh new SHA,
Wisp now builds from main today.
Version ticks to ten-point-ten,
Release notes updated with a pen.
🐇 Thump-thump goes the rabbit's cheer!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: building wisp from a specific main HEAD as a 0.5.10:1 test build.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-wisp-v0.5.10

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
Dockerfile (1)

29-35: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

Pin WISP to an immutable ref
--branch main --depth 1 still follows a moving tip, so the build will start failing as soon as upstream main advances. Use a tag or a commit checkout from a full clone instead of comparing after the fact.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Dockerfile` around lines 29 - 35, The WISP fetch in the Dockerfile is still
tied to a moving branch, so replace the current clone-from-branch flow in the
WISP install step with an immutable ref based on the WISP_VERSION/WISP_COMMIT
inputs. Update the RUN step that performs the git clone and HEAD_SHA check so it
checks out the pinned commit or tag directly from a full clone, and remove the
post-clone mismatch verification as the source should no longer track main.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Dockerfile`:
- Around line 26-30: Update the stale Dockerfile comment above WISP_VERSION and
WISP_COMMIT so it matches the current setup: this is no longer a release-tag
pin, but a temporary test-build pin to a specific commit on main. In the
Dockerfile, adjust the wording near the ARG WISP_VERSION and ARG WISP_COMMIT
declarations to remove references to “latest upstream release” and the tag
re-point guard, and instead describe the mutable branch plus commit-based
pinning accurately.

---

Nitpick comments:
In `@Dockerfile`:
- Around line 29-35: The WISP fetch in the Dockerfile is still tied to a moving
branch, so replace the current clone-from-branch flow in the WISP install step
with an immutable ref based on the WISP_VERSION/WISP_COMMIT inputs. Update the
RUN step that performs the git clone and HEAD_SHA check so it checks out the
pinned commit or tag directly from a full clone, and remove the post-clone
mismatch verification as the source should no longer track main.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 584ddd92-fc5a-4b33-8834-6769a4ea98f7

📥 Commits

Reviewing files that changed from the base of the PR and between b9072fa and 93b9c35.

📒 Files selected for processing (2)
  • Dockerfile
  • startos/versions/current.ts

Comment thread Dockerfile
Comment on lines 26 to +30
# Pinned to the latest upstream release. Bump WISP_VERSION and WISP_COMMIT to
# update (see UPDATING.md). WISP_COMMIT is the immutable commit the tag points
# to; the guard below fails the build if the tag is ever re-pointed.
ARG WISP_VERSION=v0.5.5
ARG WISP_COMMIT=76a3261369ff4a2b5dedb778e8b1d42184800ea4
ARG WISP_VERSION=main
ARG WISP_COMMIT=d96bd0e036308e73922fa5e06b20394115ca0883

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Stale comment: no longer describes a tag-based pin.

The comment above still says "Pinned to the latest upstream release" and references "the guard below fails the build if the tag is ever re-pointed", but WISP_VERSION is now main (a mutable branch), not a release tag. Please update the comment to reflect that this is a temporary test-build pin to a specific commit on main, not a release tag.

📝 Suggested comment update
-# Pinned to the latest upstream release. Bump WISP_VERSION and WISP_COMMIT to
-# update (see UPDATING.md). WISP_COMMIT is the immutable commit the tag points
-# to; the guard below fails the build if the tag is ever re-pointed.
+# TEST BUILD: pinned to a specific commit on main (past the v0.5.10 tag).
+# Bump WISP_VERSION and WISP_COMMIT to update (see UPDATING.md). The guard
+# below fails the build if the branch tip no longer matches WISP_COMMIT.
 ARG WISP_VERSION=main
 ARG WISP_COMMIT=d96bd0e036308e73922fa5e06b20394115ca0883
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Pinned to the latest upstream release. Bump WISP_VERSION and WISP_COMMIT to
# update (see UPDATING.md). WISP_COMMIT is the immutable commit the tag points
# to; the guard below fails the build if the tag is ever re-pointed.
ARG WISP_VERSION=v0.5.5
ARG WISP_COMMIT=76a3261369ff4a2b5dedb778e8b1d42184800ea4
ARG WISP_VERSION=main
ARG WISP_COMMIT=d96bd0e036308e73922fa5e06b20394115ca0883
# TEST BUILD: pinned to a specific commit on main (past the v0.5.10 tag).
# Bump WISP_VERSION and WISP_COMMIT to update (see UPDATING.md). The guard
# below fails the build if the branch tip no longer matches WISP_COMMIT.
ARG WISP_VERSION=main
ARG WISP_COMMIT=d96bd0e036308e73922fa5e06b20394115ca0883
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Dockerfile` around lines 26 - 30, Update the stale Dockerfile comment above
WISP_VERSION and WISP_COMMIT so it matches the current setup: this is no longer
a release-tag pin, but a temporary test-build pin to a specific commit on main.
In the Dockerfile, adjust the wording near the ARG WISP_VERSION and ARG
WISP_COMMIT declarations to remove references to “latest upstream release” and
the tag re-point guard, and instead describe the mutable branch plus
commit-based pinning accurately.

@wksantiago

Copy link
Copy Markdown
Contributor Author

Superseded by dedicated branch test-build-main-head.

@wksantiago wksantiago closed this Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants