Build wisp from main HEAD (d96bd0e) as 0.5.10:1 test build - #16
Build wisp from main HEAD (d96bd0e) as 0.5.10:1 test build#16wksantiago wants to merge 8 commits into
Conversation
Update wisp to v0.5.6 (429/503 on WS upgrade connection-limit rejection)
Update wisp to v0.5.7 (shutdown use-after-free fix)
Update wisp to v0.5.9 (churn + shutdown crash fixes)
WalkthroughThis PR updates the pinned ChangesWisp Version Bump
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Dockerfile (1)
29-35: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winPin WISP to an immutable ref
--branch main --depth 1still follows a moving tip, so the build will start failing as soon as upstreammainadvances. Use a tag or a commit checkout from a full clone instead of comparing after the fact.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Dockerfile` around lines 29 - 35, The WISP fetch in the Dockerfile is still tied to a moving branch, so replace the current clone-from-branch flow in the WISP install step with an immutable ref based on the WISP_VERSION/WISP_COMMIT inputs. Update the RUN step that performs the git clone and HEAD_SHA check so it checks out the pinned commit or tag directly from a full clone, and remove the post-clone mismatch verification as the source should no longer track main.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Dockerfile`:
- Around line 26-30: Update the stale Dockerfile comment above WISP_VERSION and
WISP_COMMIT so it matches the current setup: this is no longer a release-tag
pin, but a temporary test-build pin to a specific commit on main. In the
Dockerfile, adjust the wording near the ARG WISP_VERSION and ARG WISP_COMMIT
declarations to remove references to “latest upstream release” and the tag
re-point guard, and instead describe the mutable branch plus commit-based
pinning accurately.
---
Nitpick comments:
In `@Dockerfile`:
- Around line 29-35: The WISP fetch in the Dockerfile is still tied to a moving
branch, so replace the current clone-from-branch flow in the WISP install step
with an immutable ref based on the WISP_VERSION/WISP_COMMIT inputs. Update the
RUN step that performs the git clone and HEAD_SHA check so it checks out the
pinned commit or tag directly from a full clone, and remove the post-clone
mismatch verification as the source should no longer track main.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 584ddd92-fc5a-4b33-8834-6769a4ea98f7
📒 Files selected for processing (2)
Dockerfilestartos/versions/current.ts
| # Pinned to the latest upstream release. Bump WISP_VERSION and WISP_COMMIT to | ||
| # update (see UPDATING.md). WISP_COMMIT is the immutable commit the tag points | ||
| # to; the guard below fails the build if the tag is ever re-pointed. | ||
| ARG WISP_VERSION=v0.5.5 | ||
| ARG WISP_COMMIT=76a3261369ff4a2b5dedb778e8b1d42184800ea4 | ||
| ARG WISP_VERSION=main | ||
| ARG WISP_COMMIT=d96bd0e036308e73922fa5e06b20394115ca0883 |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Stale comment: no longer describes a tag-based pin.
The comment above still says "Pinned to the latest upstream release" and references "the guard below fails the build if the tag is ever re-pointed", but WISP_VERSION is now main (a mutable branch), not a release tag. Please update the comment to reflect that this is a temporary test-build pin to a specific commit on main, not a release tag.
📝 Suggested comment update
-# Pinned to the latest upstream release. Bump WISP_VERSION and WISP_COMMIT to
-# update (see UPDATING.md). WISP_COMMIT is the immutable commit the tag points
-# to; the guard below fails the build if the tag is ever re-pointed.
+# TEST BUILD: pinned to a specific commit on main (past the v0.5.10 tag).
+# Bump WISP_VERSION and WISP_COMMIT to update (see UPDATING.md). The guard
+# below fails the build if the branch tip no longer matches WISP_COMMIT.
ARG WISP_VERSION=main
ARG WISP_COMMIT=d96bd0e036308e73922fa5e06b20394115ca0883📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # Pinned to the latest upstream release. Bump WISP_VERSION and WISP_COMMIT to | |
| # update (see UPDATING.md). WISP_COMMIT is the immutable commit the tag points | |
| # to; the guard below fails the build if the tag is ever re-pointed. | |
| ARG WISP_VERSION=v0.5.5 | |
| ARG WISP_COMMIT=76a3261369ff4a2b5dedb778e8b1d42184800ea4 | |
| ARG WISP_VERSION=main | |
| ARG WISP_COMMIT=d96bd0e036308e73922fa5e06b20394115ca0883 | |
| # TEST BUILD: pinned to a specific commit on main (past the v0.5.10 tag). | |
| # Bump WISP_VERSION and WISP_COMMIT to update (see UPDATING.md). The guard | |
| # below fails the build if the branch tip no longer matches WISP_COMMIT. | |
| ARG WISP_VERSION=main | |
| ARG WISP_COMMIT=d96bd0e036308e73922fa5e06b20394115ca0883 |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Dockerfile` around lines 26 - 30, Update the stale Dockerfile comment above
WISP_VERSION and WISP_COMMIT so it matches the current setup: this is no longer
a release-tag pin, but a temporary test-build pin to a specific commit on main.
In the Dockerfile, adjust the wording near the ARG WISP_VERSION and ARG
WISP_COMMIT declarations to remove references to “latest upstream release” and
the tag re-point guard, and instead describe the mutable branch plus
commit-based pinning accurately.
|
Superseded by dedicated branch test-build-main-head. |
Summary by CodeRabbit