Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds a metadata factory and structured-data helpers, introduces a JsonLd component, normalizes base URLs to https://www.prisma.io, updates many page metadata exports to use createPageMetadata (adding path/ogImage), injects JSON-LD on events/pricing, adjusts layout (analytics scripts and nav), and updates several static links. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (1)
apps/site/src/lib/page-metadata.ts (1)
18-18: Improve consistency: convert OG/Twitter image URLs to explicit absolute URLs.The canonical URL on line 18 is correctly built as an absolute URL. However, the OG and Twitter image fields (lines 33, 36, 39) pass relative paths directly, relying on implicit
metadataBaseresolution. While this works becausemetadataBaseis properly configured in the root layout, inconsistent URL handling—explicit absolute vs. implicit relative—reduces code clarity and maintainability.For consistency and explicitness, convert the
ogImageparameter to an absolute URL in this helper:Suggested refactor
export function createPageMetadata({ title, description, path, ogImage = "/og/og-index.png", }: PageMetadataOptions): Metadata { const pathname = path === "/" ? "/" : path.startsWith("/") ? path : `/${path}`; const url = new URL(pathname, getBaseUrl()).toString(); + const baseUrl = getBaseUrl(); + const ogImageUrl = ogImage + ? new URL(ogImage.startsWith("/") ? ogImage : `/${ogImage}`, baseUrl).toString() + : undefined; return { title, description, alternates: { canonical: url, }, openGraph: { title, description, url, siteName: "Prisma", locale: "en_US", type: "website", - images: ogImage ? [{ url: ogImage }] : undefined, + images: ogImageUrl ? [{ url: ogImageUrl }] : undefined, }, twitter: { - card: ogImage ? "summary_large_image" : "summary", + card: ogImageUrl ? "summary_large_image" : "summary", title, description, - images: ogImage ? [ogImage] : undefined, + images: ogImageUrl ? [ogImageUrl] : undefined, }, }; }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/site/src/lib/page-metadata.ts` at line 18, The OG/Twitter image URLs are left as relative paths while the canonical `url` is made absolute; update the helper to normalize `ogImage` into an explicit absolute URL by resolving it against `getBaseUrl()` (e.g., replace usages of the raw `ogImage` parameter with a computed absolute value using `new URL(ogImage, getBaseUrl()).toString()`), then use that absolute value for the Open Graph and Twitter image fields so `ogImage`, `getBaseUrl()`, and the existing `url` variable are consistently absolute.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/site/src/app/layout.tsx`:
- Around line 155-176: The GTM bootstrap (Script with id="gmanager") and Tolt
Script (Script with data-tolt="fda67739-7ed0-42d2-b716-6da0edbec191") are loaded
unconditionally; add consent handling so they only run when CookieYes consent is
granted. Fix by adding data-cookieyes-category="analytics" to the Tolt <Script>
tag and making the GTM snippet consent-aware — either wrap the GTM injection
(Script id="gmanager" dangerouslySetInnerHTML) in a component or function that
defers insertion until CookieYes fires its consent callback, or gate both
scripts behind the CookieYes callback before rendering/injecting them.
In `@apps/site/src/app/orm/page.tsx`:
- Around line 277-280: The hero CTA Button currently uses the old redirecting
URL ("https://www.prisma.io/docs/getting-started/quickstart-prismaPostgres");
update the Button component's href to the canonical path
("https://www.prisma.io/docs/concepts/prisma-orm/quickstart/prisma-postgres") to
match the footer link and avoid redirects—apply the same change for the other
Button instance referenced around the footer area (the second Button href in the
same file).
In `@apps/site/src/components/json-ld.tsx`:
- Line 11: The inline JSON-LD uses dangerouslySetInnerHTML with
JSON.stringify(data) which can be broken by embedded "</script>" sequences;
update the rendering to sanitize the serialized JSON by escaping problematic
sequences before inserting (e.g., replace occurrences of "</script" with
"<\\/script" and optionally "<!--" / "-->" if relevant) — implement a small
helper (e.g., escapeJsonForInline or sanitizeJsonLd) and use that in place of
JSON.stringify(data) in the dangerouslySetInnerHTML assignment so the JSON-LD
string is safe against script-breakout injection.
In `@apps/site/src/data/prisma-with/nextjs.json`:
- Line 99: There are placeholder blog URLs in the JSON entries where the "url"
key is set to "https://www.prisma.io/blog/post-slug" (three occurrences); update
each of those "url" values in nextjs.json to the correct, final article URLs (or
remove the card if no URL exists), making sure the replaced links are valid and
reachable before release.
In `@apps/site/src/lib/structured-data.ts`:
- Around line 18-26: The toPlainText function decodes HTML entities in the wrong
order causing sequences like "&nbsp;" to remain encoded; update the
toPlainText function to perform the & replacement before other entity
replacements (move the .replace(/&/g, "&") call to occur prior to
replacements for , ", '/', etc.) so that doubly-encoded
entities are fully decoded, keeping the stripping of tags and whitespace
normalization as-is.
In `@apps/site/src/lib/url.ts`:
- Around line 6-8: The code currently returns process.env.NEXT_PUBLIC_PRISMA_URL
raw; instead, in the function in apps/site/src/lib/url.ts that reads
NEXT_PUBLIC_PRISMA_URL, parse and validate it: ensure a scheme is present
(prepend "https://" if missing), construct a URL object and extract only the
origin (protocol + host + optional port) to strip any path or trailing slash,
and throw or return a safe default if the value is not a valid URL; use
process.env.NEXT_PUBLIC_PRISMA_URL as the source and replace the direct return
with this normalization/validation logic.
---
Nitpick comments:
In `@apps/site/src/lib/page-metadata.ts`:
- Line 18: The OG/Twitter image URLs are left as relative paths while the
canonical `url` is made absolute; update the helper to normalize `ogImage` into
an explicit absolute URL by resolving it against `getBaseUrl()` (e.g., replace
usages of the raw `ogImage` parameter with a computed absolute value using `new
URL(ogImage, getBaseUrl()).toString()`), then use that absolute value for the
Open Graph and Twitter image fields so `ogImage`, `getBaseUrl()`, and the
existing `url` variable are consistently absolute.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d5bef587-a3d7-4d3f-8a9c-786b26e239a1
⛔ Files ignored due to path filters (23)
apps/site/public/og/og-about.pngis excluded by!**/*.pngapps/site/public/og/og-client.pngis excluded by!**/*.pngapps/site/public/og/og-ecosystem.pngis excluded by!**/*.pngapps/site/public/og/og-event-code-of-conduct.pngis excluded by!**/*.pngapps/site/public/og/og-events.pngis excluded by!**/*.pngapps/site/public/og/og-migrate.pngis excluded by!**/*.pngapps/site/public/og/og-newsletter.pngis excluded by!**/*.pngapps/site/public/og/og-orm.pngis excluded by!**/*.pngapps/site/public/og/og-oss-friends.pngis excluded by!**/*.pngapps/site/public/og/og-partners-tos.pngis excluded by!**/*.pngapps/site/public/og/og-partners.pngis excluded by!**/*.pngapps/site/public/og/og-prisma-stack-apollo.pngis excluded by!**/*.pngapps/site/public/og/og-prisma-stack-express.pngis excluded by!**/*.pngapps/site/public/og/og-prisma-stack-fastify.pngis excluded by!**/*.pngapps/site/public/og/og-prisma-stack-graphql.pngis excluded by!**/*.pngapps/site/public/og/og-prisma-stack-hapi.pngis excluded by!**/*.pngapps/site/public/og/og-prisma-stack-nextjs.pngis excluded by!**/*.pngapps/site/public/og/og-prisma-stack-react.pngis excluded by!**/*.pngapps/site/public/og/og-privacy.pngis excluded by!**/*.pngapps/site/public/og/og-sla.pngis excluded by!**/*.pngapps/site/public/og/og-stack.pngis excluded by!**/*.pngapps/site/public/og/og-terms.pngis excluded by!**/*.pngapps/site/public/og/og-typedsql.pngis excluded by!**/*.png
📒 Files selected for processing (28)
apps/site/src/app/(index)/page.tsxapps/site/src/app/about/page.tsxapps/site/src/app/api/search/route.tsapps/site/src/app/client/page.tsxapps/site/src/app/ecosystem/page.tsxapps/site/src/app/event-code-of-conduct/page.tsxapps/site/src/app/events/page.tsxapps/site/src/app/layout.tsxapps/site/src/app/migrate/page.tsxapps/site/src/app/newsletter/page.tsxapps/site/src/app/orm/page.tsxapps/site/src/app/oss-friends/page.tsxapps/site/src/app/partners/page.tsxapps/site/src/app/partners/tos/page.tsxapps/site/src/app/pricing/page.tsxapps/site/src/app/privacy/page.tsxapps/site/src/app/sla/page.tsxapps/site/src/app/stack/page.tsxapps/site/src/app/support/page.tsxapps/site/src/app/terms/page.tsxapps/site/src/app/typedsql/page.tsxapps/site/src/components/homepage/card-section/default-logos.jsonapps/site/src/components/json-ld.tsxapps/site/src/data/prisma-with/nextjs.jsonapps/site/src/data/support.jsonapps/site/src/lib/page-metadata.tsapps/site/src/lib/structured-data.tsapps/site/src/lib/url.ts
Make metadata generation and inline JSON-LD safer while normalizing configured base URLs and gating analytics scripts on consent. Also remove placeholder Next.js article links and point ORM CTAs at the current Prisma Postgres quickstart. Made-with: Cursor
Escape inline JSON-LD with Unicode-safe replacements to avoid script parsing issues and update FAQ plain-text normalization to handle doubly encoded entities without reintroducing unsafe general entity decoding. Made-with: Cursor
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/site/src/app/layout.tsx (1)
80-82: Clean up trailing whitespace from removed entry.Line 81 contains only whitespace, likely leftover from removing the "Accelerate" submenu entry. This creates unnecessary noise in the codebase.
🧹 Proposed cleanup
url: "/studio", desc: "Explore and manipulate your data", }, - ], },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/site/src/app/layout.tsx` around lines 80 - 82, Remove the stray whitespace-only line left behind after the removed "Accelerate" submenu in apps/site/src/app/layout.tsx: open the JSX/array of menu items (the closing ], entry list or surrounding fragment) and delete the blank line that contains only spaces so there are no trailing-whitespace-only lines; save and run the formatter (Prettier/ESLint autofix) to ensure no trailing spaces remain.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/site/src/components/json-ld.tsx`:
- Around line 6-11: The sanitizeJsonLd function currently escapes "</script",
"<!--" and "-->" but misses the HTML5 comment end variant "--!>"; update
sanitizeJsonLd to also replace occurrences of "--!>" (e.g., .replace(/--!>/g,
"--\\!>")) so the JSON-LD string escapes that comment terminator as well,
keeping the existing replacements for "</script", "<!--", and "-->" in place.
---
Nitpick comments:
In `@apps/site/src/app/layout.tsx`:
- Around line 80-82: Remove the stray whitespace-only line left behind after the
removed "Accelerate" submenu in apps/site/src/app/layout.tsx: open the JSX/array
of menu items (the closing ], entry list or surrounding fragment) and delete the
blank line that contains only spaces so there are no trailing-whitespace-only
lines; save and run the formatter (Prettier/ESLint autofix) to ensure no
trailing spaces remain.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8560aa43-73bb-4170-a722-e3c9f9d4446f
📒 Files selected for processing (7)
apps/site/src/app/layout.tsxapps/site/src/app/orm/page.tsxapps/site/src/components/json-ld.tsxapps/site/src/data/prisma-with/nextjs.jsonapps/site/src/lib/page-metadata.tsapps/site/src/lib/structured-data.tsapps/site/src/lib/url.ts
✅ Files skipped from review due to trivial changes (2)
- apps/site/src/lib/page-metadata.ts
- apps/site/src/lib/structured-data.ts
🚧 Files skipped from review as they are similar to previous changes (2)
- apps/site/src/data/prisma-with/nextjs.json
- apps/site/src/lib/url.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Improvements