Skip to content

[codemod][lowrisk] Enable -Wunused-exception-parameter in github/PACKAGE +1 #26744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r-barnes wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[codemod][lowrisk] Enable -Wunused-exception-parameter in github/PACKAGE +1 #26744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion presto-native-execution/presto_cpp/main/PrestoServerOperations.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ std::string PrestoServerOperations::taskOperation(
limit = limitStr == proxygen::empty_string
? std::numeric_limits<uint32_t>::max()
: stoi(limitStr);
} catch (std::exception& ex) {
} catch (std::exception&) {
VELOX_USER_FAIL("Invalid limit provided '{}'.", limitStr);
}
std::stringstream oss;
Expand Down
4 changes: 2 additions & 2 deletions presto-native-execution/presto_cpp/main/TaskResource.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ proxygen::RequestHandler* TaskResource::createOrUpdateTaskImpl(
summarize,
startProcessCpuTimeNs,
receiveThrift);
} catch (const velox::VeloxException& e) {
} catch (const velox::VeloxException&) {
// Creating an empty task, putting errors inside so that next
// status fetch from coordinator will catch the error and well
// categorize it.
Expand All @@ -271,7 +271,7 @@ proxygen::RequestHandler* TaskResource::createOrUpdateTaskImpl(
std::current_exception(),
summarize,
startProcessCpuTimeNs);
} catch (const velox::VeloxUserError& e) {
} catch (const velox::VeloxUserError&) {
throw;
}
}
Expand Down
2 changes: 1 addition & 1 deletion presto-native-execution/presto_cpp/main/http/HttpServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ void sendResponse(
std::string messageBody;
try {
messageBody = body.dump();
} catch (const std::exception& e) {
} catch (const std::exception&) {
messageBody =
body.dump(-1, ' ', false, nlohmann::detail::error_handler_t::replace);
LOG(WARNING) << "Failed to serialize json to string. "
Expand Down
2 changes: 1 addition & 1 deletion presto-native-execution/presto_cpp/main/operators/BroadcastExchangeSource.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ BroadcastExchangeSource::createExchangeSource(
try {
broadcastFileInfo =
BroadcastFileInfo::deserialize(broadcastInfoJson.value());
} catch (const VeloxException& e) {
} catch (const VeloxException&) {
throw;
} catch (const std::exception& e) {
VELOX_USER_FAIL("BroadcastInfo deserialization failed: {}", e.what());
Expand Down
2 changes: 1 addition & 1 deletion presto-native-execution/presto_cpp/main/operators/ShuffleExchangeSource.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ namespace facebook::presto::operators {
#define CALL_SHUFFLE(call, methodName) \
try { \
call; \
} catch (const velox::VeloxException& e) { \
} catch (const velox::VeloxException&) { \
throw; \
} catch (const std::exception& e) { \
VELOX_FAIL("ShuffleReader::{} failed: {}", methodName, e.what()); \
Expand Down
2 changes: 1 addition & 1 deletion presto-native-execution/presto_cpp/main/operators/ShuffleWrite.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ velox::core::PlanNodeId deserializePlanNodeId(const folly::dynamic& obj) {
#define CALL_SHUFFLE(call, methodName) \
try { \
call; \
} catch (const VeloxException& e) { \
} catch (const VeloxException&) { \
throw; \
} catch (const std::exception& e) { \
VELOX_FAIL("ShuffleWriter::{} failed: {}", methodName, e.what()); \
Expand Down
8 changes: 4 additions & 4 deletions presto-native-execution/presto_cpp/main/tests/PrestoToVeloxQueryConfigTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ TEST_F(PrestoToVeloxQueryConfigTest, sessionPropertiesOverrideSystemConfigs) {
try {
expectedBytes =
toCapacity(expectedValue, config::CapacityUnit::BYTE);
} catch (const VeloxUserError& e) {
} catch (const VeloxUserError&) {
expectedBytes = std::stoull(expectedValue);
}
EXPECT_EQ(expectedBytes, config.maxOutputBufferSize());
Expand All @@ -231,7 +231,7 @@ TEST_F(PrestoToVeloxQueryConfigTest, sessionPropertiesOverrideSystemConfigs) {
try {
expectedBytes =
toCapacity(expectedValue, config::CapacityUnit::BYTE);
} catch (const VeloxUserError& e) {
} catch (const VeloxUserError&) {
expectedBytes = std::stoull(expectedValue);
}
EXPECT_EQ(expectedBytes, config.maxPartitionedOutputBufferSize());
Expand All @@ -251,7 +251,7 @@ TEST_F(PrestoToVeloxQueryConfigTest, sessionPropertiesOverrideSystemConfigs) {
try {
expectedBytes =
toCapacity(expectedValue, config::CapacityUnit::BYTE);
} catch (const VeloxUserError& e) {
} catch (const VeloxUserError&) {
expectedBytes = std::stoull(expectedValue);
}
EXPECT_EQ(
Expand All @@ -270,7 +270,7 @@ TEST_F(PrestoToVeloxQueryConfigTest, sessionPropertiesOverrideSystemConfigs) {
try {
expectedBytes =
toCapacity(expectedValue, config::CapacityUnit::BYTE);
} catch (const VeloxUserError& e) {
} catch (const VeloxUserError&) {
expectedBytes = std::stoull(expectedValue);
}
EXPECT_EQ(expectedBytes, config.maxExchangeBufferSize());
Expand Down
Loading