Skip to content

Conversation

@r-barnes
Copy link
Contributor

@r-barnes r-barnes commented Dec 4, 2025

Summary:
This diff enables compilation warning flags for the directory in question. Further details are in this workplace post.

This is a low-risk diff. There are no run-time effects and the diff has already been observed to compile locally. If the code compiles, it work; test errors are spurious.

Differential Revision: D87365532

…CKAGE +1

Summary:
This diff enables compilation warning flags for the directory in question. Further details are in [this workplace post](https://fb.workplace.com/permalink.php?story_fbid=pfbid02XaWNiCVk69r1ghfvDVpujB8Hr9Y61uDvNakxiZFa2jwiPHscVdEQwCBHrmWZSyMRl&id=100051201402394).

This is a low-risk diff. There are **no run-time effects** and the diff has already been observed to compile locally. **If the code compiles, it work; test errors are spurious.**

Differential Revision: D87365532
@r-barnes r-barnes requested review from a team as code owners December 4, 2025 21:25
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 4, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR silences -Wunused-exception-parameter warnings by removing unused exception variable names in several catch blocks across Presto native execution code and tests, without altering control flow or behavior.

File-Level Changes

Change Details Files
Update catch blocks to omit unused exception variables to comply with -Wunused-exception-parameter.
  • Replace catch clauses that name but do not use exception objects with unnamed exception parameters while preserving exception types and control flow.
  • Adjust test code in PrestoToVeloxQueryConfigTest to catch VeloxUserError by type only when falling back to std::stoull parsing.
  • Update server, task, and operator code (task creation, task operations, HTTP response serialization, broadcast/shuffle exchange, and shuffle write) to catch VeloxException or std::exception by type only when they are immediately rethrown or not inspected.
presto-native-execution/presto_cpp/main/tests/PrestoToVeloxQueryConfigTest.cpp
presto-native-execution/presto_cpp/main/TaskResource.cpp
presto-native-execution/presto_cpp/main/PrestoServerOperations.cpp
presto-native-execution/presto_cpp/main/http/HttpServer.cpp
presto-native-execution/presto_cpp/main/operators/BroadcastExchangeSource.cpp
presto-native-execution/presto_cpp/main/operators/ShuffleExchangeSource.cpp
presto-native-execution/presto_cpp/main/operators/ShuffleWrite.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants