-
-
Notifications
You must be signed in to change notification settings - Fork 120
Add Workflows for generating reference results #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fab8197
to
32db06e
Compare
cfcfa7e
to
32db06e
Compare
This PR is now ready. |
32db06e
to
1011c9d
Compare
Co-authored-by: Valentin Seitz <[email protected]>
* remove non working gha cache stuff * Move to only commits in the dockerfile --------- Co-authored-by: Valentin Seitz <[email protected]>
I also added small changes to the Dockerfile to allow for commit-ish things to be requested. |
…ls into add-wf-reference-results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks very nice!
Some comments to consider, feel free to merge afterwards.
Closes #405. This is related to #401 (git hash reporting) by requiring (only via documentation) specific Git commit or tag (not branches, which can change over time) when generating reference results. I would still feel safer if I had a dump of all hashes in one log file, but I remember from our last meeting that this is complicated due to the current architecture. I assume it still creates the same report for the current/tested results. So, yes, it closes #401 as well. Regarding #400 (contents of the archive):
|
Co-authored-by: Gerasimos Chourdakis <[email protected]>
Co-authored-by: Gerasimos Chourdakis <[email protected]>
This PR adds a reusable workflow to automagically add reference results to a certain branch.
It can be either be triggered manual or another trigger can be used to trigger the reusable workflow (e.g on creation of PR of a certain form)
It also adds more information on the machine (Still open to discussion if we acually need it). But especially the CPU ISA Extensions like AVX-512 etc are of importance.
The Pipeline now runs and is able to add commits: https://github.com/precice/tutorials/actions/runs/7181615150