Skip to content

Add Workflows for generating reference results #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Dec 14, 2023

Conversation

valentin-seitz
Copy link
Contributor

@valentin-seitz valentin-seitz commented Nov 28, 2023

This PR adds a reusable workflow to automagically add reference results to a certain branch.
It can be either be triggered manual or another trigger can be used to trigger the reusable workflow (e.g on creation of PR of a certain form)

It also adds more information on the machine (Still open to discussion if we acually need it). But especially the CPU ISA Extensions like AVX-512 etc are of importance.

The Pipeline now runs and is able to add commits: https://github.com/precice/tutorials/actions/runs/7181615150

@valentin-seitz valentin-seitz self-assigned this Nov 28, 2023
@valentin-seitz valentin-seitz linked an issue Nov 28, 2023 that may be closed by this pull request
@valentin-seitz valentin-seitz force-pushed the add-wf-reference-results branch from fab8197 to 32db06e Compare December 12, 2023 12:43
@valentin-seitz valentin-seitz marked this pull request as ready for review December 12, 2023 15:44
@valentin-seitz valentin-seitz force-pushed the add-wf-reference-results branch from cfcfa7e to 32db06e Compare December 12, 2023 15:47
@valentin-seitz
Copy link
Contributor Author

This PR is now ready.
The CI/CD Pipeline works as expected (see: https://github.com/precice/tutorials/actions/runs/7181615150)
After #420 is merged, i will rebase and then the tests should go through so we can merge.

@valentin-seitz valentin-seitz force-pushed the add-wf-reference-results branch from 32db06e to 1011c9d Compare December 12, 2023 17:00
valentin-seitz and others added 2 commits December 12, 2023 22:59
* remove non working gha cache stuff

* Move to only commits in the dockerfile

---------

Co-authored-by: Valentin Seitz <[email protected]>
@valentin-seitz valentin-seitz changed the title Add Workflows for generating reference results Add Workflows for generating reference results || Allow commits-ish things to be specified as arguments Dec 13, 2023
@valentin-seitz valentin-seitz changed the title Add Workflows for generating reference results || Allow commits-ish things to be specified as arguments Add Workflows for generating reference results Dec 13, 2023
@valentin-seitz
Copy link
Contributor Author

I also added small changes to the Dockerfile to allow for commit-ish things to be requested.

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks very nice!
Some comments to consider, feel free to merge afterwards.

@MakisH
Copy link
Member

MakisH commented Dec 14, 2023

Closes #405.

This is related to #401 (git hash reporting) by requiring (only via documentation) specific Git commit or tag (not branches, which can change over time) when generating reference results. I would still feel safer if I had a dump of all hashes in one log file, but I remember from our last meeting that this is complicated due to the current architecture. I assume it still creates the same report for the current/tested results. So, yes, it closes #401 as well.

Regarding #400 (contents of the archive):

  • reference_data is renamed to reference-results
  • TUTORIALS_REF is included in the report
  • I have not checked what the actual contents are, because I don't have an archive readily available, but I still believe it closes Contents of the system tests archive #400.

valentin-seitz and others added 2 commits December 14, 2023 14:44
Co-authored-by: Gerasimos Chourdakis <[email protected]>
Co-authored-by: Gerasimos Chourdakis <[email protected]>
@valentin-seitz valentin-seitz merged commit 1f7afd1 into develop Dec 14, 2023
@MakisH MakisH deleted the add-wf-reference-results branch December 14, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trigger generation of systemtests reference _results
2 participants