Skip to content

Systemtests: checkout named branches #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MakisH opened this issue Dec 14, 2023 · 1 comment
Open

Systemtests: checkout named branches #423

MakisH opened this issue Dec 14, 2023 · 1 comment

Comments

@MakisH
Copy link
Member

MakisH commented Dec 14, 2023

We are currently restricted in checking out specific tags or commits, due to our caching implementation. It would be very convenient if we could also reliably checkout branches.

I mean there are easy ways to do this:

  • Manipulate the Build_argument and append the current day and be okay if develop might be a day old?
  • Have a cronjob invalidate the build cache in a certain interval.
    etc.

I think using commit-ish objects is the way to go here in the long run.
Only if we see, that we rebuild a lof of the layers often or spend more time building the container than running the simuations, we might need to think about it. We then can think of trading off some consistency for performance.

https://stackoverflow.com/questions/23303549/what-are-commit-ish-and-tree-ish-in-git

Originally posted by @valentin-seitz in #410 (comment)

@MakisH
Copy link
Member Author

MakisH commented May 24, 2024

I think the easiest way to work around this is to have an option in the system tests that automatically gets the latest commit of each branch. This is what we now do in the OpenFOAM adapter CI, using the Get latest commit Action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants