input: allow layout switching and brightness/volume control under session lock - #2296
Conversation
|
The PR template is mandatory |
2834101 to
9fb075f
Compare
|
@jackpot51, I fixed the PR description |
9fb075f to
382d001
Compare
Drakulix
left a comment
There was a problem hiding this comment.
Why not simply exclude the InputSourceSwitch action from the early return when a lock screen is engaged?
382d001 to
c1c0538
Compare
|
@Drakulix, you were right, I overcomplicated this too much. Your approach is cleaner. I've rewritten the PR. I also added keys for brightness and volume control. |
leviport
left a comment
There was a problem hiding this comment.
This makes volume up/down/mute, laptop screen brightness up/down, and keyboard layout switch hotkeys work at the lock screen. It does not enable them at the initial login screen, but that's outside of the scope of this PR.
I did notice that the keyboard layout button and drop-down don't update when I change my keyboard layout with the keyboard hotkey. For example, if I have both Dvorak and QWERTY enabled and have Dvorak active, pressing Super + Space changes the layout, but clicking the layout button on the greeter reveals a drop-down with Dvorak still selected, even though QWERTY keystrokes are still being typed. I think this is a cosmic-greeter bug, so I will open an issue in that repo.
|
@leviport, I fixed it in this mr: |
Summary
Allow common multimedia keys to work on the lock screen by extending
the early-return whitelist:
Super+Space— switch keyboard layoutXF86MonBrightnessUp/Down— display brightnessXF86AudioRaiseVolume/LowerVolume,XF86AudioMute— audio outputAll added actions flow through the existing
Systemhandler.Layout switching is functional standalone (the new layout is applied and
typed-into-password fields use it), but the locker UI (dropdown checkmark
and active-layout label) will not reflect the change without the companion
pop-os/cosmic-greeter#439, which subscribes to
xkb_configupdates.Test plan
Super+Escorloginctl lock-session) and verify each key:Super+Spaceswitches layout (functional; visual update requires cosmic-greeter#439)Super+T) — still blocked