Upgrade to unstable2507 #1029

TorstenStueber · 2025-12-10T08:32:15Z

This upgrades polkadot-sdk crates to the latest version of unstable2507. The main change is the following backport: paritytech/polkadot-sdk#10552.

This is an important step for upgrading the Kusama AH runtime to the latest version of pallet-revive with:

EVM backend
Ethereum block storage
New gas mapping

…times

TorstenStueber · 2025-12-10T08:34:41Z

system-parachains/asset-hubs/asset-hub-polkadot/src/lib.rs


 impl pallet_transaction_payment::Config for Runtime {
 	type RuntimeEvent = RuntimeEvent;
-	type OnChargeTransaction = impls::tx_payment::FungiblesAdapter<


Reasoning for this change: Using FungiblesAdapter (plural) for NativeAndAsset and DotLocation is the same as using FungibleAdapter (singular) with Balances because NativeAndAsset will just forward all calls to Balances for DotLocation.

ggwpez · 2025-12-10T11:09:38Z

Cargo.toml

-pallet-election-provider-multi-block = { version = "0.3.4", default-features = false }
-pallet-staking-async = { version = "0.6.2", default-features = false }
+pallet-election-provider-multi-block = { version = "0.5.0", default-features = false }
+pallet-staking-async = { version = "0.7.0", default-features = false }


@kianenigma anything to do when bumping these?

No changes needed for this bump.

ggwpez · 2025-12-10T11:16:57Z

system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs

 	type OnChargeTransaction =
 		pallet_transaction_payment::FungibleAdapter<Balances, ResolveTo<StakingPot, Balances>>;
-	type WeightToFee = WeightToFee;
+	type WeightToFee = pallet_revive::evm::fees::BlockRatioFee<333333333, 10_815_700_000_000, Self>;


Where do these numbers come from?

This encodes the same fraction as the one in the WeightToFeePolynomial used in WeightToFee, which is defined as:

numerator: super::currency::CENTS

this is 1_000_000_000_000 / 30 / 100 = 333_333_333

denominator: 100 * Balance::from(ExtrinsicBaseWeight::get().ref_time())

this is 100 * 1_000 * 108_157 = 10_815_700_000

I corrected the value that was here before, it was wrongly calculated.

Maybe you can add a sanity check test to ensure that the fee of a simple transaction is sane?
And please put the calculation into a comment above the code so that we can reproduce it later.

I added a comment with explanation.

system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs

athei · 2025-12-10T18:02:11Z

/cmd bench --runtime asset-hub-kusama --pallet pallet_revive

system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs

system-parachains/asset-hubs/asset-hub-kusama/src/weights/pallet_revive.rs

system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs

github-actions · 2025-12-10T19:05:03Z

Command "bench --runtime asset-hub-kusama --pallet pallet_revive" has started 🚀 See logs here

github-actions · 2025-12-10T19:13:43Z

Command "bench --runtime asset-hub-kusama --pallet pallet_revive" has finished ✅ See logs here

Subweight results:

No changes found.

…times

athei · 2025-12-11T12:20:21Z

/cmd fmt

acatangiu · 2025-12-11T13:09:56Z

system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs

 	type OnChargeTransaction =
 		pallet_transaction_payment::FungibleAdapter<Balances, ResolveTo<StakingPot, Balances>>;
-	type WeightToFee = WeightToFee;
+	type WeightToFee = pallet_revive::evm::fees::BlockRatioFee<333333333, 10_815_700_000, Self>;


can you add a comment here explaining the used WeightToFee? I'm sure it will not age well without clear docs/code-comments..

I added a comment with explanation.

acatangiu · 2025-12-11T13:12:19Z

system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs

+	type DepositPerChildTrieItem = DepositPerChildTrieItem;
 	type DepositPerByte = DepositPerByte;
-	type WeightPrice = pallet_transaction_payment::Pallet<Self>;
 	// TODO(#840): use `weights::pallet_revive::WeightInfo` here


with the new pallet-revive version you should be able to fix this too, right?

I believe the benchmark is still not fixed. Also we need solc to be installed on the benchmarking bot. We don't have time to get this done right now.

acatangiu · 2025-12-11T13:21:21Z

Cargo.toml

+snowbridge-outbound-queue-runtime-api = { version = "0.17.0", default-features = false }
+snowbridge-outbound-queue-v2-runtime-api = { version = "0.6.0", default-features = false }
+snowbridge-outbound-queue-primitives = { version = "0.6.0", default-features = false }
+snowbridge-pallet-ethereum-client = { version = "0.17.0", default-features = false }
+snowbridge-pallet-inbound-queue = { version = "0.17.0", default-features = false }
+snowbridge-pallet-inbound-queue-v2 = { version = "0.6.0", default-features = false }
+snowbridge-pallet-inbound-queue-fixtures = { version = "0.25.0" }
+snowbridge-pallet-ethereum-client-fixtures = { version = "0.25.0" }
+snowbridge-pallet-outbound-queue = { version = "0.17.0", default-features = false }
+snowbridge-pallet-outbound-queue-v2 = { version = "0.6.0", default-features = false }
+snowbridge-pallet-system = { version = "0.17.0", default-features = false }
+snowbridge-pallet-system-v2 = { version = "0.6.0", default-features = false }
+snowbridge-pallet-system-frontend = { version = "0.6.0", default-features = false }
+snowbridge-inbound-queue-primitives = { version = "0.6.0", default-features = false }
+snowbridge-runtime-common = { version = "0.18.0", default-features = false }
+snowbridge-runtime-test-common = { version = "0.20.0" }
+snowbridge-system-runtime-api = { version = "0.17.0", default-features = false }
+snowbridge-system-v2-runtime-api = { version = "0.6.0", default-features = false }


@claravanstaden please confirm the snowbridge pallet versions bump

All of the version bumps are just because of crate dependency changes.

github-actions · 2025-12-11T14:26:16Z

Command "fmt" has started 🚀 See logs here

github-actions · 2025-12-11T14:27:09Z

Command "fmt" has failed ❌! See logs here

claravanstaden

To bump to the latest: https://matrix.to/#/!cqAmzdIcbOFwrdrubV:parity.io/$Kygjlcxk58wiMVkbVeiK1mAfZtLnkB8i-oVBPnoIb5I?via=parity.io&via=matrix.org&via=web3.foundation

The other Snowbridge crate bumps are correct, its just because the Snowbridge crate dependency updates.

Cargo.toml

…times

TorstenStueber · 2025-12-12T11:43:56Z

To bump to the latest: https://matrix.to/#/!cqAmzdIcbOFwrdrubV:parity.io/$Kygjlcxk58wiMVkbVeiK1mAfZtLnkB8i-oVBPnoIb5I?via=parity.io&via=matrix.org&via=web3.foundation

The other Snowbridge crate bumps are correct, its just because the Snowbridge crate dependency updates.

I bumped that crate.

github-actions · 2025-12-12T11:59:15Z

Review required! Latest push from author must always be reviewed

…times

github-actions

Found 5 issues: CI coverage risk from skipping revive fixtures, potential runtime behavior change in Asset Hub Polkadot fee charging, and several hard-coded economic/weight constants in Asset Hub Kusama that may silently drift when upstream constants change.

Suggestions that couldn't be attached to a specific line

.github/workflows/test.yml:108, 134

SKIP_PALLET_REVIVE_FIXTURES: 1 is applied to both cargo test --all-features and benchmarking runs. This reduces signal from CI exactly in the area being upgraded (revive/EVM). If skipping fixtures is required for performance/stability, consider limiting it to benchmarking only, or adding a separate test job that runs without SKIP_PALLET_REVIVE_FIXTURES (even if allowed to be slower) to keep upgrade safety.

system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs:1690, 1713

pallet_revive::evm::tx_extension::SetOrigin was added to both the normal TxExtension tuple and the Ethereum EthExtra tuple. If SetOrigin is meant only for Ethereum transactions, including it in the global TxExtension risks affecting (or at least adding overhead to) all extrinsics, and could introduce subtle origin/validation differences for non-EVM calls. Confirm SetOrigin is a no-op for non-Ethereum extrinsics; otherwise, move it exclusively into the Ethereum-specific EthExtra path (or gate it behind an extension wrapper that only runs for Ethereum extrinsic types).

github-actions · 2025-12-13T20:59:49Z

.github/workflows/clippy.yml

        env:
          RUSTFLAGS: "-D warnings"
          SKIP_WASM_BUILD: 1
+          SKIP_PALLET_REVIVE_FIXTURES: 1


Setting SKIP_PALLET_REVIVE_FIXTURES: 1 disables fixture-related work during clippy. If fixture generation/validation is part of catching breaking changes in pallet-revive (especially around EVM backend), this can mask regressions. Consider scoping this env var only to jobs where fixtures are irrelevant, or add a dedicated (possibly nightly/optional) job that still runs fixture generation/validation so upgrades don’t silently break it.

github-actions · 2025-12-13T20:59:50Z

system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs

+	// The two generic parameters of `BlockRatioFee` define a rational number that defines the
+	// ref_time to fee mapping. The numbers chosen here are exactly the same as the one from the
+	// `WeightToFeePolynomial` that was used before:
+	// - The numerator is `currency::CENTS` = 1_000_000_000_000 / 30 / 100 = 333_333_333
+	// - The denominator is `100 * Balance::from(ExtrinsicBaseWeight::get().ref_time())`
+	//   - which is 100 * 1_000 * 108_157 = 10_815_700_000
+	type WeightToFee = pallet_revive::evm::fees::BlockRatioFee<333333333, 10_815_700_000, Self>;


WeightToFee was changed to pallet_revive::evm::fees::BlockRatioFee<333333333, 10_815_700_000, Self> with hard-coded numerator/denominator values. This is brittle: if ExtrinsicBaseWeight (or the fee polynomial inputs) change in a future SDK bump, the mapping will silently diverge from the intended economics. Prefer deriving these constants from shared constants (or using the prior WeightToFeePolynomial-based approach) so the mapping updates with upstream changes, or at least centralize these numbers as named consts with a comment pointing to the exact upstream source/version they were taken from.

github-actions · 2025-12-13T20:59:50Z

system-parachains/asset-hubs/asset-hub-polkadot/src/lib.rs

+	type OnChargeTransaction =
+		pallet_transaction_payment::FungibleAdapter<Balances, ResolveTo<StakingPot, Balances>>;


pallet_transaction_payment::Config::OnChargeTransaction changed from a custom fungibles-based adapter (removed in impls.rs) to pallet_transaction_payment::FungibleAdapter<Balances, ResolveTo<StakingPot, Balances>>. This can be a breaking behavior change if Asset Hub Polkadot relied on fungibles credits (e.g., for pallet_asset_conversion_tx_payment integration and paying fees via assets), as the removed adapter explicitly handled fungibles credits and refunds. Verify that asset-based fee payment still works as intended after this change; if it’s still required, keep a fungibles-compatible OnChargeTransaction (or replace it with the new upstream equivalent, if polkadot-sdk now provides one) so ChargeAssetTxPayment/swap adapters aren’t implicitly disabled.

Prefund Ethereum style testnet accounts

TorstenStueber added 2 commits December 10, 2025 05:25

Update crates to unstable2507

4d07c65

Merge branch 'main' of https://github.com/TorstenStueber/polkadot-run…

5137407

…times

TorstenStueber commented Dec 10, 2025

View reviewed changes

ggwpez reviewed Dec 10, 2025

View reviewed changes

athei reviewed Dec 10, 2025

View reviewed changes

TorstenStueber added 3 commits December 10, 2025 18:08

Add PR feedback

e931c2e

Correct the WeightToFee multiplier

79d5244

Disable fixture compilation for clippy

78f1882

Ank4n mentioned this pull request Dec 11, 2025

[unstable2507] Backport #10311: [Staking] Async Election and Export paritytech/polkadot-sdk#10526

Merged

TorstenStueber added 3 commits December 11, 2025 07:55

Merge branch 'main' into main

43e1bb4

Fix CI

82c8b76

Merge branch 'main' of https://github.com/TorstenStueber/polkadot-run…

7871e45

…times

Fix fmt and change config values

11e5bed

acatangiu approved these changes Dec 11, 2025

View reviewed changes

ggwpez approved these changes Dec 11, 2025

View reviewed changes

athei approved these changes Dec 11, 2025

View reviewed changes

al3mart mentioned this pull request Dec 11, 2025

release: v1.19.3 paseo-network/passet-hub#33

Merged

claravanstaden reviewed Dec 11, 2025

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

claravanstaden and others added 4 commits December 12, 2025 10:23

Update Cargo.toml

18a091f

Merge branch 'main' into main

85ca8d8

Upgrade snowbridge crates

f7cb372

Merge branch 'main' of https://github.com/TorstenStueber/polkadot-run…

46fb585

…times

Ank4n mentioned this pull request Dec 12, 2025

[KAH] Enable buffered election export #1034

Closed

github-actions bot requested review from acatangiu, athei and ggwpez December 12, 2025 11:59

acatangiu approved these changes Dec 12, 2025

View reviewed changes

lexnv mentioned this pull request Dec 12, 2025

asset-hub-kusama: Prepare ElasticScaling with 3 cores on asset hub kusama and enable buffered election export #1018

Open

claravanstaden approved these changes Dec 12, 2025

View reviewed changes

ggwpez approved these changes Dec 12, 2025

View reviewed changes

Fix tests

85062cf

github-actions bot requested review from acatangiu, claravanstaden and ggwpez December 12, 2025 21:38

ggwpez removed request for acatangiu, athei, claravanstaden and ggwpez December 12, 2025 22:36

Merge branch 'main' into main

fee3345

github-actions bot requested review from acatangiu, athei, claravanstaden and ggwpez December 13, 2025 00:20

claravanstaden approved these changes Dec 13, 2025

View reviewed changes

TorstenStueber added 2 commits December 13, 2025 08:17

Fix tests (2)

7e919bc

Merge branch 'main' of https://github.com/TorstenStueber/polkadot-run…

1917107

…times

github-actions bot requested a review from claravanstaden December 13, 2025 11:22

athei added 2 commits December 13, 2025 16:32

Fund ethereum well known keys

b7b0b24

Map testnet accounts so that they can be used with pallet_revive

01448b0

github-actions bot reviewed Dec 13, 2025

View reviewed changes

Merge pull request #1 from polkadot-fellows/at/prefunded

dc700e1

Prefund Ethereum style testnet accounts

		type OnChargeTransaction =
		pallet_transaction_payment::FungibleAdapter<Balances, ResolveTo<StakingPot, Balances>>;

Upgrade to unstable2507 #1029

Are you sure you want to change the base?

Upgrade to unstable2507 #1029

Uh oh!

Conversation

TorstenStueber commented Dec 10, 2025

Uh oh!

TorstenStueber Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TorstenStueber Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ggwpez Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

athei commented Dec 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 10, 2025

Uh oh!

github-actions bot commented Dec 10, 2025

Uh oh!

athei commented Dec 11, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 11, 2025

Uh oh!

github-actions bot commented Dec 11, 2025

Uh oh!

claravanstaden left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TorstenStueber commented Dec 12, 2025

Uh oh!

github-actions bot commented Dec 12, 2025

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Suggestions that couldn't be attached to a specific line

Uh oh!

github-actions bot Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Dec 13, 2025

TorstenStueber Dec 10, 2025 •

edited

Loading

TorstenStueber Dec 11, 2025 •

edited

Loading

ggwpez Dec 11, 2025 •

edited

Loading

claravanstaden left a comment •

edited

Loading