-
Notifications
You must be signed in to change notification settings - Fork 141
asset-hub-kusama: Prepare ElasticScaling with 3 cores on asset hub kusama and enable buffered election export #1018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
|
Review required! Latest push from author must always be reviewed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found one issue regarding a duplicated constant definition which could lead to future maintenance problems.
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
|
A small followup on staking side: paritytech/polkadot-sdk#10311 has been now merged (cc @Ank4n ). |
To give more context: multi-cores can lead to shorter eras (good to avoid but not disaster). The #10311 would mitigate that (and can go to Kusama before audit is done). I will make a PR with the changes to the runtime once its backported to 2507. |
|
Indeed, let's align and include both PRs:
in a release. It looks like more tests are failing and we really need paritytech/polkadot-sdk#10541 to unblock the CI here 🙏 |
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
This reverts commit 1e762d5.
Signed-off-by: Alexandru Vasile <[email protected]>
…ata (#10541) This PR ensures that the parachains test-utils crate has 2 relay parent descendants for testing purposes. Effectively fixes a panic because we missed this mock data for chains that started with `RP_offset > 0`: ``` Unable to verify provided relay parent descendants. expected_rp_descendants_num: 1 error: InvalidNumberOfDescendants { expected: 2, received: 0 } note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` Detected in: - https://github.com/polkadot-fellows/runtimes/actions/runs/19857064730/job/56897622908?pr=1018 Unblocks: - polkadot-fellows/runtimes#1018 Inspired by a similar fix I've introduced in: - #9880 --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <[email protected]>
…ata (#10541) This PR ensures that the parachains test-utils crate has 2 relay parent descendants for testing purposes. Effectively fixes a panic because we missed this mock data for chains that started with `RP_offset > 0`: ``` Unable to verify provided relay parent descendants. expected_rp_descendants_num: 1 error: InvalidNumberOfDescendants { expected: 2, received: 0 } note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` Detected in: - https://github.com/polkadot-fellows/runtimes/actions/runs/19857064730/job/56897622908?pr=1018 Unblocks: - polkadot-fellows/runtimes#1018 Inspired by a similar fix I've introduced in: - #9880 --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <[email protected]> (cherry picked from commit 0f28d81)
…s-3-cores-ahk Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
|
Have rebased this PR on top of:
The changes added from my part are limited to:
|
This PR configures the AssetHubKusama runtime to utilize elastic scaling with 3 cores.
cc @skunert @sandreim