add more configurable options via env vars

[erral]

No description provided.

[erral]

@1letter

[1letter]

@erral sholud not be the max_request_body_size config value also configurable in the zope.ini ?

[server:main]
use = egg:waitress#main
host = 0.0.0.0
port = 8080
threads = 2
clear_untrusted_proxy_headers = false
max_request_body_size = 1073741824

[erral]

@erral sholud not be the max_request_body_size config value also configurable in the zope.ini ?

[server:main]
use = egg:waitress#main
host = 0.0.0.0
port = 8080
threads = 2
clear_untrusted_proxy_headers = false
max_request_body_size = 1073741824

Mmm.... right. Should it be ZOPE_FORM_MEMORY_LIMIT or another new variable?

[1letter]

Mmm.... right. Should it be ZOPE_FORM_MEMORY_LIMIT or another new variable?

max_request_body_size should be equal or greater form-memory-limit, for me is it not important how much vars are involved, the main thing is: it should be configurable ;-)

[erral]

Sorry @1letter I don't know how to do this with environment variables, it looks like they are not available when building the ini file and we would require some kind of search and replace, but I don't know whether this is the right solution.

[davisagli]

Possibly zope.ini could be built from instance.yaml using cookiecutter-zope-instance at image build time, but that should probably be a separate PR. This one looks okay to me.

[davisagli]

@erral I think the CI is failing on trying to log in to Docker Hub since you submitted this PR from a fork. Could you open a new one from a branch in this repository? I just sent an invite to the Installers team which should give you access.

[erral]

@erral I think the CI is failing on trying to log in to Docker Hub since you submitted this PR from a fork. Could you open a new one from a branch in this repository? I just sent an invite to the Installers team which should give you access.

Done, thanks!