Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more configurable options via env vars (6.1.x) #158

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

erral
Copy link
Member

@erral erral commented Jan 28, 2025

See #153 for discussion

skeleton/docker-entrypoint.sh Outdated Show resolved Hide resolved
@jensens
Copy link
Member

jensens commented Jan 29, 2025

Instead of blowing this up here I would go for using cookie-cutter-zope-instance which supports all available options already. It comes with a helper transform-from-environment.py to turn environment variables into settings.

@davisagli
Copy link
Member

davisagli commented Jan 30, 2025

@jensens I like that idea, but we also need to be careful we don't break things if cookiecutter-zope-instance uses different environment variable names from the ones that have been here for some time. Maybe someone can investigate at the Alpine City sprint?

Also note I already merged the same change to the 6.0.x branch

@jensens
Copy link
Member

jensens commented Jan 30, 2025

It uses different names, indeed. We could add a compat layer and deprecate the old names for a while. +1 for more at ACS

@mauritsvanrees mauritsvanrees dismissed davisagli’s stale review January 31, 2025 10:14

Requested change has been done.

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the same PR on 6.0.x was already approved and merged, I will do the same here. Afterwards I will make a PR for 6.1.0rc1 which is now ready.

@mauritsvanrees mauritsvanrees merged commit 74dfd79 into 6.1.x Jan 31, 2025
3 checks passed
@mauritsvanrees mauritsvanrees deleted the erral-more-configurable-vars-6.1 branch January 31, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants