Support dynamic IP registration #370
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #370 +/- ##
==========================================
+ Coverage 84.28% 84.34% +0.06%
==========================================
Files 41 41
Lines 3149 3194 +45
==========================================
+ Hits 2654 2694 +40
- Misses 356 359 +3
- Partials 139 141 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vnet/router.go
Outdated
| func (r *Router) AddIPToNIC(nic NIC, ip net.IP) error { | ||
| r.mutex.Lock() | ||
| defer r.mutex.Unlock() | ||
|
|
||
| if !r.ipv4Net.Contains(ip) { | ||
| return fmt.Errorf("%w: %s", errStaticIPisBeyondSubnet, r.ipv4Net.String()) | ||
| } | ||
| r.nics[ip.String()] = nic | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
This is a useful feature to add. but i don't think router is the right layer, In vnet's design addresses belong to the interface/net and the router should drive that from that state.
We also need clear semantics around: collision/overwrite behavior, or whether move ip vs alias. Also should this be called before or after start? and how the state will update or state consistent.
I think it should be somewhere in interface, with add / remove API. and update the child routers somehow.
There was a problem hiding this comment.
Fair point, just pushed a change that allows the addresses to be added through net which adds it to the nic.
There was a problem hiding this comment.
@JoTurk Just following up. Anything else we need to do here?
There was a problem hiding this comment.
Sorry i didn't notice that you updated the PR, i'll check when i wake up.
wrangelvid
force-pushed
the
add_ip_to_nic
branch
from
86602a5 to
dfd4524
Compare
wrangelvid
changed the title
wrangelvid
force-pushed
the
add_ip_to_nic
branch
from
dfd4524 to
37ee413
Compare
2 participants
Add the ability to register IP addresses with the router after Start() has been called.
For the vnet test in pion/webrtc#3323 we need to test gathering new ice candiates. We could do this by adding new interfaces on the fly, but I figured it might be easier to just change the address like dhcp.