-
Notifications
You must be signed in to change notification settings - Fork 64
Add Net.CreateListenConfig #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #373 +/- ##
==========================================
- Coverage 84.34% 84.25% -0.09%
==========================================
Files 41 41
Lines 3194 3208 +14
==========================================
+ Hits 2694 2703 +9
- Misses 359 363 +4
- Partials 141 142 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@rg0now is it possible to fix the API compatibility? maybe we should keep transport.Net unchanged and introduce the option as an extension interface. |
|
@JoTurk I agree API breakage would be best to avoid. Here is a typical point where we want to use this. The idea is that we create a custom How to make this work? Do you have a concrete suggestion? Happy to redo this |
|
@JoTurk I think it might be ok! If we bump Sorry if I put lots of anxiety on people around major version dumps. It's just a bummer that more people still use v3 vs v4. 2x more still import v3 and would love to fix that :'( https://pkg.go.dev/github.com/pion/webrtc/v3 |
JoTurk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah i was a semver absolute with my comment, there are work arounds but they are all seems to be ugly.
73a28e7 to
c64d0b1
Compare
c64d0b1 to
eb98700
Compare
Description
Wrap
net.ListenConfigto allow customizing vnet Listeners.Reference issue
Related pion/turn#514